From: "Jan Beulich" <JBeulich@suse.com>
To: Paul Bolle <pebolle@tiscali.nl>, Martin Walch <walch.martin@web.de>
Cc: akpm@linux-foundation.org, Sam Ravnborg <sam@ravnborg.org>,
Michal Marek <mmarek@suse.cz>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Kconfig: drop bogus default values
Date: Tue, 24 Mar 2015 07:38:23 +0000 [thread overview]
Message-ID: <5511227F020000780006CD25@mail.emea.novell.com> (raw)
In-Reply-To: <178407860.0zoJnDfCo1@tacticalops>
>>> On 23.03.15 at 22:08, <walch.martin@web.de> wrote:
> On Thursday 12 March 2015 13:11:47 Paul Bolle wrote:
>> On Wed, 2015-03-11 at 13:59 +0000, Jan Beulich wrote:
>> > Default "no" is pretty pointless for options without (visible) prompts:
>>
>> Related: is there ever a situation where using "default n" or "def_bool
>> n" makes sense (whether or not the entry has a prompt)? I think I once
>> thought of one but I can't remember it at all, so I guess my memory is
>> fooling me.
>
> Your memory is right. It is rarely used, but there is an application for
> using a plain "default n": to overwrite an existing other default value.
> Particularly in one special case this is desired: Let us say there is a
> symbol that may lack a visible prompt, but has the default value y set in
> a Kconfig file that is used across all architectures. If there is a single
> architecture that must have the default value n then it is possible to
> override the default y in the global file with a default n in the
> architecture specific file.
>
> A real world case is PCI_QUIRKS in the mainline kernel:
>
> init/Kconfig:1554: default y
> arch/s390/Kconfig:59: def_bool n
>
> When setting PCI!=n && EXPERT=n then on each architecture PCI_QUIRKS=y
> except on s390 where PCI_QUIRKS=n.
But iirc such redundant defaults yield warnings (or at least at
some point in the past they did).
Jan
prev parent reply other threads:[~2015-03-24 7:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 13:59 [PATCH] Kconfig: drop bogus default values Jan Beulich
2015-03-12 12:11 ` Paul Bolle
2015-03-12 12:36 ` Jan Beulich
2015-03-12 12:41 ` Paul Bolle
2015-03-12 18:51 ` Sam Ravnborg
2015-03-23 21:08 ` Martin Walch
2015-03-23 21:24 ` Paul Bolle
2015-03-23 22:58 ` Martin Walch
2015-03-24 7:39 ` Jan Beulich
2015-03-24 7:38 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5511227F020000780006CD25@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=pebolle@tiscali.nl \
--cc=sam@ravnborg.org \
--cc=walch.martin@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox