public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: David VomLehn <dvomlehn@gmail.com>, linux-kbuild@vger.kernel.org
Cc: yann.morin.1998@free.fr
Subject: Re: [PATCH] kconfig: Add support for floating point configuration variables
Date: Sun, 12 Apr 2015 19:44:04 -0700	[thread overview]
Message-ID: <552B2D74.7020304@infradead.org> (raw)
In-Reply-To: <20150412211624.GA19749@localhost.localdomain>

On 04/12/15 14:16, David VomLehn wrote:
> Add support for floating point configuration variables using C syntax.

Missing justification.

Missing explanation (or deletion) of
+FILE *log_fp; etc.


> ---
>  kconfig-frontends/docs/kconfig-language.txt |    2 +-
>  kconfig-frontends/frontends/conf/conf.c     |    3 +++
>  kconfig-frontends/frontends/gconf/gconf.c   |    3 +++
>  kconfig-frontends/frontends/mconf/mconf.c   |    4 ++++
>  kconfig-frontends/frontends/nconf/nconf.c   |    3 +++
>  kconfig-frontends/frontends/qconf/qconf.cc  |    3 +++
>  kconfig-frontends/libs/parser/symbol.c      |   24 +++++++++++++++++++++---
>  kconfig-frontends/utils/gettext.c           |    3 +++
>  8 files changed, 41 insertions(+), 4 deletions(-)


-- 
~Randy

  reply	other threads:[~2015-04-13  2:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-12 21:16 [PATCH] kconfig: Add support for floating point configuration variables David VomLehn
2015-04-13  2:44 ` Randy Dunlap [this message]
2015-04-13  6:54   ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552B2D74.7020304@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=dvomlehn@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox