linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] kbuild/tags.sh: use cscope -q option for building symbol db
@ 2015-04-16 19:14 Jesse Barnes
  2015-04-16 19:37 ` Paul Bolle
  0 siblings, 1 reply; 3+ messages in thread
From: Jesse Barnes @ 2015-04-16 19:14 UTC (permalink / raw)
  To: linux-kbuild; +Cc: mmarek

This takes up a bit more disk space, but really improves symbol lookup
performance.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 scripts/tags.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/tags.sh b/scripts/tags.sh
index cdb491d..bb35d83 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -142,7 +142,7 @@ all_defconfigs()
 docscope()
 {
 	(echo \-k; echo \-q; all_target_sources) > cscope.files
-	cscope -b -f cscope.out
+	cscope -q -b -f cscope.out
 }
 
 dogtags()
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] kbuild/tags.sh: use cscope -q option for building symbol db
  2015-04-16 19:14 [PATCH] kbuild/tags.sh: use cscope -q option for building symbol db Jesse Barnes
@ 2015-04-16 19:37 ` Paul Bolle
  2015-04-16 19:48   ` Jesse Barnes
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2015-04-16 19:37 UTC (permalink / raw)
  To: Jesse Barnes; +Cc: linux-kbuild, mmarek

On Thu, 2015-04-16 at 12:14 -0700, Jesse Barnes wrote:
> This takes up a bit more disk space, but really improves symbol lookup
> performance.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> ---
>  scripts/tags.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index cdb491d..bb35d83 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -142,7 +142,7 @@ all_defconfigs()
>  docscope()
>  {
>  	(echo \-k; echo \-q; all_target_sources) > cscope.files

There's an "echo -q" there.

> -	cscope -b -f cscope.out
> +	cscope -q -b -f cscope.out
>  }
>  
>  dogtags()

man cscope tells me:
    The -I, -c, -k, -p, -q, and -T options can also be in the cscope.files file

Doesn't the above do that correctly?


Paul Bolle


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kbuild/tags.sh: use cscope -q option for building symbol db
  2015-04-16 19:37 ` Paul Bolle
@ 2015-04-16 19:48   ` Jesse Barnes
  0 siblings, 0 replies; 3+ messages in thread
From: Jesse Barnes @ 2015-04-16 19:48 UTC (permalink / raw)
  To: Paul Bolle; +Cc: linux-kbuild, mmarek

On 04/16/2015 12:37 PM, Paul Bolle wrote:
> On Thu, 2015-04-16 at 12:14 -0700, Jesse Barnes wrote:
>> This takes up a bit more disk space, but really improves symbol lookup
>> performance.
>>
>> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>> ---
>>  scripts/tags.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/tags.sh b/scripts/tags.sh
>> index cdb491d..bb35d83 100755
>> --- a/scripts/tags.sh
>> +++ b/scripts/tags.sh
>> @@ -142,7 +142,7 @@ all_defconfigs()
>>  docscope()
>>  {
>>  	(echo \-k; echo \-q; all_target_sources) > cscope.files
> 
> There's an "echo -q" there.
> 
>> -	cscope -b -f cscope.out
>> +	cscope -q -b -f cscope.out
>>  }
>>  
>>  dogtags()
> 
> man cscope tells me:
>     The -I, -c, -k, -p, -q, and -T options can also be in the cscope.files file
> 
> Doesn't the above do that correctly?

I missed that... when I did 'make cscope' after adding the -q option
things must have just gotten faster due to it all being cached, rather
than a change in the db.

Sorry for the noise!

Thanks,
Jesse

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-04-16 19:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-16 19:14 [PATCH] kbuild/tags.sh: use cscope -q option for building symbol db Jesse Barnes
2015-04-16 19:37 ` Paul Bolle
2015-04-16 19:48   ` Jesse Barnes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).