From: Michal Marek <mmarek@suse.cz>
To: Chris J Arges <chris.j.arges@canonical.com>,
linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] builddeb: parallelize debug module installation
Date: Mon, 27 Apr 2015 16:22:43 +0200 [thread overview]
Message-ID: <553E4633.8080606@suse.cz> (raw)
In-Reply-To: <1429899940-32366-3-git-send-email-chris.j.arges@canonical.com>
On 2015-04-24 20:25, Chris J Arges wrote:
> When building the dbg package, we use a large 'for module in $(find' loop that
> can be easily parallelized by using 'find | xargs'. This patch modifies this
> loop to use the later paradigm.
>
> Signed-off-by: Chris J Arges <chris.j.arges@canonical.com>
> ---
> scripts/package/builddeb | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index 88dbf23..d12d062 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -152,16 +152,17 @@ if grep -q '^CONFIG_MODULES=y' $KCONFIG_CONFIG ; then
> rmdir "$tmpdir/lib/modules/$version"
> fi
> if [ -n "$BUILD_DEBUG" ] ; then
> - for module in $(find $tmpdir/lib/modules/ -name *.ko -printf '%P\n'); do
> - module=lib/modules/$module
> - mkdir -p $(dirname $dbg_dir/usr/lib/debug/$module)
> + find $tmpdir/lib/modules/ -name *.ko -printf '%P\n' | xargs -I {} sh -c '
I guess you want to use the -P option here.
Michal
next prev parent reply other threads:[~2015-04-27 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 18:25 [PATCH 0/2] make deb-pkg build speed improvements Chris J Arges
2015-04-24 18:25 ` [PATCH 1/2] package: Makefile: ensure $MAKE can use jobserver Chris J Arges
2015-04-28 8:38 ` Riku Voipio
2015-04-24 18:25 ` [PATCH 2/2] builddeb: parallelize debug module installation Chris J Arges
2015-04-27 14:22 ` Michal Marek [this message]
2015-04-27 16:43 ` [PATCH v2] " Chris J Arges
2015-04-28 8:57 ` Riku Voipio
2015-04-28 10:05 ` Michal Marek
2015-04-28 12:22 ` Chris J Arges
2015-04-28 13:24 ` [PATCH v3] " Chris J Arges
-- strict thread matches above, loose matches on Subject: below --
2015-05-11 14:02 [PATCH RESEND 0/2] make deb-pkg build speed improvements Chris J Arges
2015-05-11 14:02 ` [PATCH 2/2] builddeb: parallelize debug module installation Chris J Arges
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553E4633.8080606@suse.cz \
--to=mmarek@suse.cz \
--cc=chris.j.arges@canonical.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).