[PATCHv4 1/1] deb-pkg: Add device tree blobs to the package

[PATCHv4 1/1] deb-pkg: Add device tree blobs to the package

[Arnaud Patard]

[-- Attachment #1: builddeb-install-dtbs-if-needed.patch --]
[-- Type: text/plain, Size: 1232 bytes --]

When building a package with make deb-pkg (say, for arm), the dtb files are
not added to the package. Given that things are still evolving on arm, it
make sense to have them along with the kernel and modules.

v4: Use $KCONFIG_CONFIG
v3: handle with OF but without dtbs_install.
    Use $MAKE ... as done everywhere else in the script
v2: make use of dtbs_install

Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
---

Index: linux-next/scripts/package/builddeb
===================================================================
--- linux-next.orig/scripts/package/builddeb	2015-01-14 13:04:45.845922441 +0100
+++ linux-next/scripts/package/builddeb	2015-01-28 09:25:15.298796403 +0100
@@ -143,6 +143,13 @@ else
 	cp arch/$ARCH/boot/$KBUILD_IMAGE "$tmpdir/$installed_image_path"
 fi
 
+if grep -q "^CONFIG_OF=y" $KCONFIG_CONFIG ; then
+	# Only some architectures with OF support have this target
+	if grep -q dtbs_install "${srctree}/arch/$SRCARCH/Makefile"; then
+		$MAKE KBUILD_SRC= INSTALL_DTBS_PATH="$tmpdir/usr/lib/$packagename" dtbs_install
+	fi
+fi
+
 if grep -q '^CONFIG_MODULES=y' $KCONFIG_CONFIG ; then
 	INSTALL_MOD_PATH="$tmpdir" $MAKE KBUILD_SRC= modules_install
 	rm -f "$tmpdir/lib/modules/$version/build"

Re: [PATCHv4 1/1] deb-pkg: Add device tree blobs to the package

[Ben Hutchings]

[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]

On Tue, 2015-02-03 at 13:16 +0100, Arnaud Patard wrote:
> When building a package with make deb-pkg (say, for arm), the dtb files are
> not added to the package. Given that things are still evolving on arm, it
> make sense to have them along with the kernel and modules.
> 
> v4: Use $KCONFIG_CONFIG
> v3: handle with OF but without dtbs_install.
>     Use $MAKE ... as done everywhere else in the script
> v2: make use of dtbs_install
> 
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>

Reviewed-by: Ben Hutchings <ben@decadent.org.uk>

> ---
> 
> Index: linux-next/scripts/package/builddeb
> ===================================================================
> --- linux-next.orig/scripts/package/builddeb    2015-01-14 13:04:45.845922441 +0100
> +++ linux-next/scripts/package/builddeb 2015-01-28 09:25:15.298796403 +0100
> @@ -143,6 +143,13 @@ else
>         cp arch/$ARCH/boot/$KBUILD_IMAGE "$tmpdir/$installed_image_path"
>  fi
>  
> +if grep -q "^CONFIG_OF=y" $KCONFIG_CONFIG ; then
> +       # Only some architectures with OF support have this target
> +       if grep -q dtbs_install "${srctree}/arch/$SRCARCH/Makefile"; then
> +               $MAKE KBUILD_SRC= INSTALL_DTBS_PATH="$tmpdir/usr/lib/$packagename" dtbs_install
> +       fi
> +fi
> +
>  if grep -q '^CONFIG_MODULES=y' $KCONFIG_CONFIG ; then
>         INSTALL_MOD_PATH="$tmpdir" $MAKE KBUILD_SRC= modules_install
>         rm -f "$tmpdir/lib/modules/$version/build"
> 

-- 
Ben Hutchings
Hoare's Law of Large Problems:
        Inside every large problem is a small problem struggling to get out.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

Re: [PATCHv4 1/1] deb-pkg: Add device tree blobs to the package

[maximilian attems]

On Tue, Feb 03, 2015 at 01:16:33PM +0100, Arnaud Patard wrote:
> When building a package with make deb-pkg (say, for arm), the dtb files are
> not added to the package. Given that things are still evolving on arm, it
> make sense to have them along with the kernel and modules.
> 
> v4: Use $KCONFIG_CONFIG
> v3: handle with OF but without dtbs_install.
>     Use $MAKE ... as done everywhere else in the script
> v2: make use of dtbs_install
> 
> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
> ---

the patch seems to apply to current linus with 
Hunk #1 succeeded at 143 with fuzz 1.

acked.

Re: [PATCHv4 1/1] deb-pkg: Add device tree blobs to the package

[Michal Marek]

Dne 22.4.2015 v 23:55 maximilian attems napsal(a):
> On Tue, Feb 03, 2015 at 01:16:33PM +0100, Arnaud Patard wrote:
>> When building a package with make deb-pkg (say, for arm), the dtb files are
>> not added to the package. Given that things are still evolving on arm, it
>> make sense to have them along with the kernel and modules.
>>
>> v4: Use $KCONFIG_CONFIG
>> v3: handle with OF but without dtbs_install.
>>     Use $MAKE ... as done everywhere else in the script
>> v2: make use of dtbs_install
>>
>> Signed-off-by: Arnaud Patard <arnaud.patard@rtp-net.org>
>> ---
> 
> the patch seems to apply to current linus with 
> Hunk #1 succeeded at 143 with fuzz 1.
> 
> acked.

Applied to kbuild.git#misc now, sorry for the delay.

Michal