linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.com>
To: Feng Wu <feng.wu@intel.com>,
	pbonzini@redhat.com, alex.williamson@redhat.com
Cc: eric.auger@linaro.org, linux-kbuild@vger.kernel.org,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] Add virt directory to the top Makefile
Date: Tue, 22 Sep 2015 11:20:20 +0200	[thread overview]
Message-ID: <56011D54.10305@suse.com> (raw)
In-Reply-To: <1442911649-149474-1-git-send-email-feng.wu@intel.com>

On 2015-09-22 10:47, Feng Wu wrote:
> We need to build files in virt/lib/, which are now used by
> KVM and VFIO, so add virt directory to the top Makefile.
> 
> Signed-off-by: Feng Wu <feng.wu@intel.com>
> ---
>  Makefile              | 8 +++++---
>  arch/x86/kvm/Makefile | 3 ---
>  virt/Makefile         | 1 +
>  3 files changed, 6 insertions(+), 6 deletions(-)
>  create mode 100644 virt/Makefile

I assume this will go through the kvm tree, is that correct?


>  vmlinux-dirs	:= $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \
>  		     $(core-y) $(core-m) $(drivers-y) $(drivers-m) \
> -		     $(net-y) $(net-m) $(libs-y) $(libs-m)))
> +		     $(net-y) $(net-m) $(libs-y) $(libs-m) $(virt-y)))

This allows to drop the explicit 'virt' entry in the KBUILD_ALLDIRS
assignment a few lines below.


> diff --git a/virt/Makefile b/virt/Makefile
> new file mode 100644
> index 0000000..335dc0b
> --- /dev/null
> +++ b/virt/Makefile
> @@ -0,0 +1 @@
> +obj-y	+= ./lib/

Remove the ./

Michal

  reply	other threads:[~2015-09-22  9:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22  8:47 [PATCH] Add virt directory to the top Makefile Feng Wu
2015-09-22  9:20 ` Michal Marek [this message]
2015-09-22 10:14   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56011D54.10305@suse.com \
    --to=mmarek@suse.com \
    --cc=alex.williamson@redhat.com \
    --cc=eric.auger@linaro.org \
    --cc=feng.wu@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).