From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:46688 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755600AbbJAGuT (ORCPT ); Thu, 1 Oct 2015 02:50:19 -0400 Subject: Re: [RFC PATCH 1/2] scripts/kconfig/Makefile: Allow KBUILD_DEFCONFIG to be a target References: <1442986835-13985-1-git-send-email-mpe@ellerman.id.au> <560275FC.60104@suse.com> <5605B2AE.1080409@suse.com> <1443680055.16900.0.camel@ellerman.id.au> From: Michal Marek Message-ID: <560CD7A6.2040905@suse.com> Date: Thu, 1 Oct 2015 08:50:14 +0200 MIME-Version: 1.0 In-Reply-To: <1443680055.16900.0.camel@ellerman.id.au> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Michael Ellerman Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, yann.morin.1998@free.fr On 2015-10-01 08:14, Michael Ellerman wrote: > On Fri, 2015-09-25 at 22:46 +0200, Michal Marek wrote: >> Dne 24.9.2015 v 00:16 Michael Ellerman napsal(a): >>> >>> >>> On 23 September 2015 19:50:52 GMT+10:00, Michal Marek >>> wrote: >>>> On 2015-09-23 07:40, Michael Ellerman wrote: >>>>> +else ifneq ($(wildcard >>>> arch/$(SRCARCH)/configs/$(KBUILD_DEFCONFIG)),) >>>>> @$(kecho) "*** Default configuration is based on >>>> '$(KBUILD_DEFCONFIG)'" >>>>> $(Q)$< $(silent) >>>> --defconfig=arch/$(SRCARCH)/configs/$(KBUILD_DEFCONFIG) $(Kconfig) >>>>> +else + @$(kecho) "*** Default configuration is based on target >>>> '$(KBUILD_DEFCONFIG)'" >>>>> + $(Q)$(MAKE) -f $(srctree)/Makefile $(KBUILD_DEFCONFIG) endif >>>> >>>> What is the anticipated usage of this? The patch is not needed to >>>> make >>>> >>>> make ppc64le_defconfig >>>> >>>> work with the second patch. If it was, this would create a loop >>>> anyway. >>> >>> The idea is to make 'make defconfig' work when KBUILD_DEFCONFIG is >>> ppc64le_defconfig (which happens for us when uname returns ppc64le) >>> and additionally when ppc64le_defconfig is not a real file. >> >> Ah, that makes sense. You can add >> >> Acked-by: Michal Marek >> >> if you want. > > Thanks. I'll assume by that you mean you're happy if I take both patches > through the powerpc tree. Yes, I assumed that this was your plan. Michal