* [PATCH] kselftest: add cleankselftest rule
@ 2015-09-23 9:33 Wang Long
2015-09-30 13:36 ` Shuah Khan
2015-10-01 1:17 ` Michael Ellerman
0 siblings, 2 replies; 9+ messages in thread
From: Wang Long @ 2015-09-23 9:33 UTC (permalink / raw)
To: shuahkh, mmarek
Cc: long.wanglong, linux-kbuild, linux-kernel, wanglong, peifeiyue
We use
$make TARGETS="size timers" kselftest
to build and run selftests. but there is no rule
for us to clean the kselftest generated files.
This patch add the rules, for example:
$ make TARGETS="size timers" cleankselftest
can clean all kselftst generated files.
Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile
index 84f4b31..c25d139 100644
--- a/Makefile
+++ b/Makefile
@@ -1075,6 +1075,9 @@ PHONY += kselftest
kselftest:
$(Q)$(MAKE) -C tools/testing/selftests run_tests
+cleankselftest:
+ $(Q)$(MAKE) -C tools/testing/selftests clean
+
# ---------------------------------------------------------------------------
# Modules
@@ -1282,6 +1285,7 @@ help:
@echo ' kselftest - Build and run kernel selftest (run as root)'
@echo ' Build, install, and boot kernel before'
@echo ' running kselftest on it'
+ @echo ' cleankselftest - Remove all generated kselftest files'
@echo ''
@echo 'Kernel packaging:'
@$(MAKE) $(build)=$(package-dir) help
--
1.8.3.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] kselftest: add cleankselftest rule
2015-09-23 9:33 [PATCH] kselftest: add cleankselftest rule Wang Long
@ 2015-09-30 13:36 ` Shuah Khan
2015-10-01 1:17 ` Michael Ellerman
1 sibling, 0 replies; 9+ messages in thread
From: Shuah Khan @ 2015-09-30 13:36 UTC (permalink / raw)
To: Wang Long, mmarek; +Cc: linux-kbuild, linux-kernel, wanglong, peifeiyue
On 09/23/2015 03:33 AM, Wang Long wrote:
> We use
>
> $make TARGETS="size timers" kselftest
>
> to build and run selftests. but there is no rule
> for us to clean the kselftest generated files.
>
> This patch add the rules, for example:
>
> $ make TARGETS="size timers" cleankselftest
>
> can clean all kselftst generated files.
>
> Signed-off-by: Wang Long <long.wanglong@huawei.com>
Thanks. Applied to linux-kselftest next for 4.4
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kselftest: add cleankselftest rule
2015-09-23 9:33 [PATCH] kselftest: add cleankselftest rule Wang Long
2015-09-30 13:36 ` Shuah Khan
@ 2015-10-01 1:17 ` Michael Ellerman
2015-10-02 14:18 ` Shuah Khan
1 sibling, 1 reply; 9+ messages in thread
From: Michael Ellerman @ 2015-10-01 1:17 UTC (permalink / raw)
To: Wang Long
Cc: shuahkh, mmarek, linux-kbuild, linux-kernel, wanglong, peifeiyue
On Wed, 2015-09-23 at 09:33 +0000, Wang Long wrote:
> We use
>
> $make TARGETS="size timers" kselftest
>
> to build and run selftests. but there is no rule
> for us to clean the kselftest generated files.
>
> This patch add the rules, for example:
>
> $ make TARGETS="size timers" cleankselftest
I think 'kselftest-clean' would be neater.
That way all the kselftests targets start with 'kselftest'.
cheers
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kselftest: add cleankselftest rule
2015-10-01 1:17 ` Michael Ellerman
@ 2015-10-02 14:18 ` Shuah Khan
2015-10-08 2:37 ` long.wanglong
2015-10-08 2:41 ` [PATCH v2] kselftest: add kselftest-clean rule Wang Long
0 siblings, 2 replies; 9+ messages in thread
From: Shuah Khan @ 2015-10-02 14:18 UTC (permalink / raw)
To: Michael Ellerman, Wang Long
Cc: mmarek, linux-kbuild, linux-kernel, wanglong, peifeiyue,
Shuah Khan
On 09/30/2015 07:17 PM, Michael Ellerman wrote:
> On Wed, 2015-09-23 at 09:33 +0000, Wang Long wrote:
>> We use
>>
>> $make TARGETS="size timers" kselftest
>>
>> to build and run selftests. but there is no rule
>> for us to clean the kselftest generated files.
>>
>> This patch add the rules, for example:
>>
>> $ make TARGETS="size timers" cleankselftest
>
> I think 'kselftest-clean' would be neater.
>
> That way all the kselftests targets start with 'kselftest'.
>
Good suggestion. Wang! Could you please send me updated patch
with this suggested change.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kselftest: add cleankselftest rule
2015-10-02 14:18 ` Shuah Khan
@ 2015-10-08 2:37 ` long.wanglong
2015-10-08 2:41 ` [PATCH v2] kselftest: add kselftest-clean rule Wang Long
1 sibling, 0 replies; 9+ messages in thread
From: long.wanglong @ 2015-10-08 2:37 UTC (permalink / raw)
To: Shuah Khan
Cc: Michael Ellerman, mmarek, linux-kbuild, linux-kernel, wanglong,
peifeiyue
On 2015/10/2 22:18, Shuah Khan wrote:
> On 09/30/2015 07:17 PM, Michael Ellerman wrote:
>> On Wed, 2015-09-23 at 09:33 +0000, Wang Long wrote:
>>> We use
>>>
>>> $make TARGETS="size timers" kselftest
>>>
>>> to build and run selftests. but there is no rule
>>> for us to clean the kselftest generated files.
>>>
>>> This patch add the rules, for example:
>>>
>>> $ make TARGETS="size timers" cleankselftest
>>
>> I think 'kselftest-clean' would be neater.
>>
>> That way all the kselftests targets start with 'kselftest'.
>>
>
> Good suggestion. Wang! Could you please send me updated patch
> with this suggested change.
OK.
Since the National Day holiday, I am sorry so late reply.
I will send the updated patch.
Thanks.
>
> thanks,
> -- Shuah
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] kselftest: add kselftest-clean rule
2015-10-02 14:18 ` Shuah Khan
2015-10-08 2:37 ` long.wanglong
@ 2015-10-08 2:41 ` Wang Long
2015-10-08 3:52 ` Michael Ellerman
1 sibling, 1 reply; 9+ messages in thread
From: Wang Long @ 2015-10-08 2:41 UTC (permalink / raw)
To: shuahkh; +Cc: mpe, mmarek, linux-kbuild, linux-kernel, peifeiyue
We use
$make TARGETS="size timers" kselftest
to build and run selftests. but there is no rule
for us to clean the kselftest generated files.
This patch add the rules, for example:
$ make TARGETS="size timers" kselftest-clean
can clean all kselftest generated files.
Signed-off-by: Wang Long <long.wanglong@huawei.com>
---
Makefile | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Makefile b/Makefile
index 1d341eb..3edd7b3 100644
--- a/Makefile
+++ b/Makefile
@@ -1075,6 +1075,9 @@ PHONY += kselftest
kselftest:
$(Q)$(MAKE) -C tools/testing/selftests run_tests
+kselftest-clean:
+ $(Q)$(MAKE) -C tools/testing/selftests clean
+
# ---------------------------------------------------------------------------
# Modules
@@ -1282,6 +1285,7 @@ help:
@echo ' kselftest - Build and run kernel selftest (run as root)'
@echo ' Build, install, and boot kernel before'
@echo ' running kselftest on it'
+ @echo ' kselftest-clean - Remove all generated kselftest files'
@echo ''
@echo 'Kernel packaging:'
@$(MAKE) $(build)=$(package-dir) help
--
1.8.3.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] kselftest: add kselftest-clean rule
2015-10-08 2:41 ` [PATCH v2] kselftest: add kselftest-clean rule Wang Long
@ 2015-10-08 3:52 ` Michael Ellerman
2015-10-08 12:21 ` Michal Marek
0 siblings, 1 reply; 9+ messages in thread
From: Michael Ellerman @ 2015-10-08 3:52 UTC (permalink / raw)
To: Wang Long; +Cc: shuahkh, mmarek, linux-kbuild, linux-kernel, peifeiyue
On Thu, 2015-10-08 at 02:41 +0000, Wang Long wrote:
> We use
>
> $make TARGETS="size timers" kselftest
>
> to build and run selftests. but there is no rule
> for us to clean the kselftest generated files.
>
> This patch add the rules, for example:
>
> $ make TARGETS="size timers" kselftest-clean
>
> can clean all kselftest generated files.
>
> Signed-off-by: Wang Long <long.wanglong@huawei.com>
> ---
> Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
Thanks that's much neater.
Acked-by: Michael Ellerman <mpe@ellerman.id.au>
cheers
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] kselftest: add kselftest-clean rule
2015-10-08 3:52 ` Michael Ellerman
@ 2015-10-08 12:21 ` Michal Marek
2015-10-08 13:26 ` Shuah Khan
0 siblings, 1 reply; 9+ messages in thread
From: Michal Marek @ 2015-10-08 12:21 UTC (permalink / raw)
To: Michael Ellerman
Cc: Wang Long, shuahkh, mmarek, linux-kbuild, linux-kernel, peifeiyue
On Thu, Oct 08, 2015 at 02:52:04PM +1100, Michael Ellerman wrote:
> On Thu, 2015-10-08 at 02:41 +0000, Wang Long wrote:
> > We use
> >
> > $make TARGETS="size timers" kselftest
> >
> > to build and run selftests. but there is no rule
> > for us to clean the kselftest generated files.
> >
> > This patch add the rules, for example:
> >
> > $ make TARGETS="size timers" kselftest-clean
> >
> > can clean all kselftest generated files.
> >
> > Signed-off-by: Wang Long <long.wanglong@huawei.com>
> > ---
> > Makefile | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> Thanks that's much neater.
>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Applied to kbuild.git#kbuild.
Michal
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] kselftest: add kselftest-clean rule
2015-10-08 12:21 ` Michal Marek
@ 2015-10-08 13:26 ` Shuah Khan
0 siblings, 0 replies; 9+ messages in thread
From: Shuah Khan @ 2015-10-08 13:26 UTC (permalink / raw)
To: Michal Marek, Michael Ellerman
Cc: Wang Long, mmarek, linux-kbuild, linux-kernel, peifeiyue
On 10/08/2015 06:21 AM, Michal Marek wrote:
> On Thu, Oct 08, 2015 at 02:52:04PM +1100, Michael Ellerman wrote:
>> On Thu, 2015-10-08 at 02:41 +0000, Wang Long wrote:
>>> We use
>>>
>>> $make TARGETS="size timers" kselftest
>>>
>>> to build and run selftests. but there is no rule
>>> for us to clean the kselftest generated files.
>>>
>>> This patch add the rules, for example:
>>>
>>> $ make TARGETS="size timers" kselftest-clean
>>>
>>> can clean all kselftest generated files.
>>>
>>> Signed-off-by: Wang Long <long.wanglong@huawei.com>
>>> ---
>>> Makefile | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>
>> Thanks that's much neater.
>>
>> Acked-by: Michael Ellerman <mpe@ellerman.id.au>
>
> Applied to kbuild.git#kbuild.
>
Thanks for getting this in.
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-10-08 13:26 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-23 9:33 [PATCH] kselftest: add cleankselftest rule Wang Long
2015-09-30 13:36 ` Shuah Khan
2015-10-01 1:17 ` Michael Ellerman
2015-10-02 14:18 ` Shuah Khan
2015-10-08 2:37 ` long.wanglong
2015-10-08 2:41 ` [PATCH v2] kselftest: add kselftest-clean rule Wang Long
2015-10-08 3:52 ` Michael Ellerman
2015-10-08 12:21 ` Michal Marek
2015-10-08 13:26 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).