From: Michal Marek <mmarek@suse.com>
To: Sedat Dilek <sedat.dilek@gmail.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: llvmlinux: Fix -fno-delete-null-pointer-checks compiler-flag
Date: Mon, 26 Oct 2015 21:01:46 +0100 [thread overview]
Message-ID: <562E86AA.6080405@suse.com> (raw)
In-Reply-To: <1442286180-11050-1-git-send-email-sedat.dilek@gmail.com>
Dne 15.9.2015 v 05:03 Sedat Dilek napsal(a):
> CLANG (here: v3.7) does not support '-fno-delete-null-pointer-checks'
> as a compiler-flag.
>
> Fix the HOSTCFLAGS and KBUILD_CFLAGS settings accordingly.
> Furthermore, move and correct the $HOSTCC check.
>
> Tested against Linux v4.3-rc1 and a refreshed llvmlinux patchset.
> ---
> Makefile | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index aaf1d52bc646..4249441e535d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -300,9 +300,9 @@ HOSTCXX = g++
> HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -std=gnu89
> HOSTCXXFLAGS = -O2
>
> -ifeq ($(shell $(HOSTCC) -v 2>&1 | grep -c "clang version"), 1)
> -HOSTCFLAGS += -Wno-unused-value -Wno-unused-parameter \
> - -Wno-missing-field-initializers -fno-delete-null-pointer-checks
> +HOSTCFLAGS += -Wno-unused-value -Wno-unused-parameter -Wno-missing-field-initializers
You are enabling the -Wno-* options for gcc with this.
Michal
prev parent reply other threads:[~2015-10-26 20:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 3:03 [PATCH] kbuild: llvmlinux: Fix -fno-delete-null-pointer-checks compiler-flag Sedat Dilek
2015-10-26 20:01 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562E86AA.6080405@suse.com \
--to=mmarek@suse.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).