linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] deb-pkg: Add automatic support for armhf architecture
@ 2015-09-28  1:34 Ben Hutchings
  2015-10-22 10:28 ` Riku Voipio
  0 siblings, 1 reply; 3+ messages in thread
From: Ben Hutchings @ 2015-09-28  1:34 UTC (permalink / raw)
  To: linux-kbuild
  Cc: maximilian attems, Michal Marek, Fathi Boudra, debian-arm,
	Hector Oron, Ian Campbell, Riku Voipio

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

The Debian armhf architecture uses the ARM EABI hard-float variant,
whereas armel uses the soft-float variant.  Although the kernel
doesn't use FP itself, CONFIG_VFP must be enabled to support
hard-float userland and will probably be disabled when supporting a
soft-float userland.  So set the architecture to armhf by default when
CONFIG_AEABI and CONFIG_VFP are both enabled.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
Acked-by: Fathi Boudra <fathi.boudra@linaro.org>
---
v2: rebased
v3: rebased

 scripts/package/builddeb | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -52,7 +52,16 @@ set_debarch() {
 	arm64)
 		debarch=arm64 ;;
 	arm*)
-		debarch=arm$(grep -q CONFIG_AEABI=y $KCONFIG_CONFIG && echo el || true) ;;
+		if grep -q CONFIG_AEABI=y $KCONFIG_CONFIG; then
+		    if grep -q CONFIG_VFP=y $KCONFIG_CONFIG; then
+			debarch=armhf
+		    else
+			debarch=armel
+		    fi
+		else
+		    debarch=arm
+		fi
+		;;
 	*)
 		debarch=$(dpkg --print-architecture)
 		echo "" >&2
-- 
Ben Hutchings
All extremists should be taken out and shot.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] deb-pkg: Add automatic support for armhf architecture
  2015-09-28  1:34 [PATCH v3] deb-pkg: Add automatic support for armhf architecture Ben Hutchings
@ 2015-10-22 10:28 ` Riku Voipio
  2015-10-26 21:36   ` Michal Marek
  0 siblings, 1 reply; 3+ messages in thread
From: Riku Voipio @ 2015-10-22 10:28 UTC (permalink / raw)
  To: Ben Hutchings
  Cc: linux-kbuild, maximilian attems, Michal Marek, debian-arm,
	Ian Campbell

On 28 September 2015 at 04:34, Ben Hutchings <ben@decadent.org.uk> wrote:
> The Debian armhf architecture uses the ARM EABI hard-float variant,
> whereas armel uses the soft-float variant.  Although the kernel
> doesn't use FP itself, CONFIG_VFP must be enabled to support
> hard-float userland and will probably be disabled when supporting a
> soft-float userland.  So set the architecture to armhf by default when
> CONFIG_AEABI and CONFIG_VFP are both enabled.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> Acked-by: Ian Campbell <ijc@hellion.org.uk>
> Acked-by: Fathi Boudra <fathi.boudra@linaro.org>

Reviewed-by: Riku Voipio <riku.voipio@linaro.org>

> ---
> v2: rebased
> v3: rebased
>
>  scripts/package/builddeb | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
>
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -52,7 +52,16 @@ set_debarch() {
>         arm64)
>                 debarch=arm64 ;;
>         arm*)
> -               debarch=arm$(grep -q CONFIG_AEABI=y $KCONFIG_CONFIG && echo el || true) ;;
> +               if grep -q CONFIG_AEABI=y $KCONFIG_CONFIG; then
> +                   if grep -q CONFIG_VFP=y $KCONFIG_CONFIG; then
> +                       debarch=armhf
> +                   else
> +                       debarch=armel
> +                   fi
> +               else
> +                   debarch=arm
> +               fi
> +               ;;
>         *)
>                 debarch=$(dpkg --print-architecture)
>                 echo "" >&2
> --
> Ben Hutchings
> All extremists should be taken out and shot.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] deb-pkg: Add automatic support for armhf architecture
  2015-10-22 10:28 ` Riku Voipio
@ 2015-10-26 21:36   ` Michal Marek
  0 siblings, 0 replies; 3+ messages in thread
From: Michal Marek @ 2015-10-26 21:36 UTC (permalink / raw)
  To: Riku Voipio, Ben Hutchings
  Cc: linux-kbuild, maximilian attems, debian-arm, Ian Campbell

Dne 22.10.2015 v 12:28 Riku Voipio napsal(a):
> On 28 September 2015 at 04:34, Ben Hutchings <ben@decadent.org.uk> wrote:
>> The Debian armhf architecture uses the ARM EABI hard-float variant,
>> whereas armel uses the soft-float variant.  Although the kernel
>> doesn't use FP itself, CONFIG_VFP must be enabled to support
>> hard-float userland and will probably be disabled when supporting a
>> soft-float userland.  So set the architecture to armhf by default when
>> CONFIG_AEABI and CONFIG_VFP are both enabled.
>>
>> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
>> Acked-by: Ian Campbell <ijc@hellion.org.uk>
>> Acked-by: Fathi Boudra <fathi.boudra@linaro.org>
> 
> Reviewed-by: Riku Voipio <riku.voipio@linaro.org>

Applied to kbuild.git#misc.

Michal


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-10-26 21:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-28  1:34 [PATCH v3] deb-pkg: Add automatic support for armhf architecture Ben Hutchings
2015-10-22 10:28 ` Riku Voipio
2015-10-26 21:36   ` Michal Marek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).