From: Michal Marek <mmarek@suse.com>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: "Yann E. MORIN" <yann.morin.1998@free.fr>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] Mark files generated by confdata.c
Date: Tue, 27 Oct 2015 22:16:11 +0100 [thread overview]
Message-ID: <562FE99B.2020108@suse.com> (raw)
In-Reply-To: <1445959842-1960-5-git-send-email-hofrat@osadl.org>
Dne 27.10.2015 v 16:30 Nicholas Mc Guire napsal(a):
> scripts/kconfig/confdata.c generates a number of files - indicate the
> location of the generator in the file heading to ease reading the sources.
>
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> This is no actual code change - compile-testing should thus do
> checkpatch.pl will fuss about "WARNING: quoted string split across lines"
> but it seems this is fine in this case given the initial code.
>
> Compile tested with x86_64_defconfig
>
> Patch is against 4.3-rc6 (localversion-next is -next-20151022)
>
> scripts/kconfig/confdata.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index 0b7dc2f..6a2be59 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -651,7 +651,8 @@ conf_write_heading(FILE *fp, struct conf_printer *printer, void *printer_arg)
>
> snprintf(buf, sizeof(buf),
> "\n"
> - "Automatically generated file; DO NOT EDIT.\n"
> + "Automatically generated by scripts/kconfig/confdata.c:"
> + " DO NOT EDIT.\n"
You cannot run the C source to regenerate the file, so how about
"generated by kconfig"?
Michal
next prev parent reply other threads:[~2015-10-27 21:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-27 15:30 [PATCH 0/4] Add generator notes to generated files Nicholas Mc Guire
2015-10-27 15:30 ` [PATCH 1/4] version.h: Make it clear where the files was generated Nicholas Mc Guire
2015-10-27 15:30 ` [PATCH 2/4] utsrelease.h: Make it clear where files are generated Nicholas Mc Guire
2015-10-27 15:30 ` [PATCH 3/4] mkcompile_h: add the generator location to compile.h Nicholas Mc Guire
2015-10-27 15:30 ` [PATCH 4/4] Mark files generated by confdata.c Nicholas Mc Guire
2015-10-27 21:16 ` Michal Marek [this message]
2015-10-28 8:00 ` Nicholas Mc Guire
2015-10-28 8:03 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562FE99B.2020108@suse.com \
--to=mmarek@suse.com \
--cc=hofrat@osadl.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yann.morin.1998@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).