From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:40795 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932296AbbLGRTZ (ORCPT ); Mon, 7 Dec 2015 12:19:25 -0500 Subject: Re: [PATCH v2 8/8] treewide: Remove newlines inside DEFINE_PER_CPU() macros References: <1449242787-16598-1-git-send-email-mmarek@suse.com> <1449242787-16598-9-git-send-email-mmarek@suse.com> <063D6719AE5E284EB5DD2968C1650D6D1CBE695F@AcuExch.aculab.com> <5665B9A0.5060009@suse.com> <1449507861.7162.1.camel@perches.com> From: Michal Marek Message-ID: <5665BF99.3090508@suse.com> Date: Mon, 7 Dec 2015 18:19:21 +0100 MIME-Version: 1.0 In-Reply-To: <1449507861.7162.1.camel@perches.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Joe Perches Cc: David Laight , "linux-kbuild@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "linux-acpi@vger.kernel.org" , "rds-devel@oss.oracle.com" , "netdev@vger.kernel.org" On 2015-12-07 18:04, Joe Perches wrote: > On Mon, 2015-12-07 at 17:53 +0100, Michal Marek wrote: >> On 2015-12-07 17:33, David Laight wrote: >>> From: Michal Marek >>>> Sent: 04 December 2015 15:26 >>>> Otherwise make tags can't parse them: >>>> >>>> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern "\1" >>> ... >>> >>> Seems to me you need to fix ctags. >> >> I'm sure the maintainers of ctags and etags would accept patches to >> describe a custom context-free grammar via commandline options, but >> until then, let's continue using the regular expressions in tags.sh and >> remove newlines in macros that tags.sh is trying to expand. >> > > Do you have a list of the most common macros? In practice, it's only DEFINE_PER_CPU and its sibling DEFINE_PER_CPU_SHARED_ALIGNED, where we try to pick the second argument to the macro and the first argument can be lengthy. > Perhaps it'd be good to add exceptions to checkpatch > 80 column line rules for them. Your call. But this is a fairly rare occurrence -- 10 cases so far. Michal