From: Michal Marek <mmarek@suse.com>
To: Kieran Bingham <kieran@kbingham.co.uk>
Cc: linux-kbuild@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>,
Lee Jones <lee.jones@linaro.org>,
Peter Griffin <peter.griffin@linaro.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Dependency issue through subdir's
Date: Mon, 25 Jan 2016 14:22:15 +0100 [thread overview]
Message-ID: <56A62187.3070805@suse.com> (raw)
In-Reply-To: <56A6080C.2070006@kbingham.co.uk>
On 2016-01-25 12:33, Kieran Bingham wrote:
> This is functional on a make -j1 build, however at -j2 and above (from a
> clean build), kbuild attempts to generate my file before
> include/generated/timeconst.h resulting in the following error:
>
> --- 8< ---
> GEN scripts/gdb/linux/constants.py
> In file included from sources/linux/include/linux/ktime.h:25:0,
> from /linux/include/linux/rcupdate.h:47,
> from /linux/include/linux/rbtree.h:34,
> from /linux/include/linux/mm_types.h:9,
> from /linux/arch/x86/include/asm/pgtable.h:448,
> from /linux/scripts/gdb/linux/constants.py.in:16:
> sources/linux/include/linux/jiffies.h:10:33: fatal error:
> generated/timeconst.h: No such file or directory
> --- >8 ---
[...]
> 2) Move the code that generates this file to /Kbuild. However I don't
> like the idea of putting non-essential generator at the top level build
You can keep the code in scripts/gdb/..., just move it out of $(always)
and have the toplevel Kbuild file call something like
$(MAKE) $(obj)=scripts/gdb/linux build_constants
> 3) Add #ifndef __GENERATE_CONSTANTS_PY__ across any reference to
> generated header files, such as in ktime.h, and define that with my
> Preprocessor statement.
If you do not need the generated headers, this might be the least evil.
We already have the COMPILE_OFFSETS and __GENERATING_BOUNDS_H defines
for a similar purpose.
Michal
next prev parent reply other threads:[~2016-01-25 13:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 11:33 Dependency issue through subdir's Kieran Bingham
2016-01-25 13:22 ` Michal Marek [this message]
2016-01-25 16:22 ` Kieran Bingham
2016-01-25 16:25 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A62187.3070805@suse.com \
--to=mmarek@suse.com \
--cc=jan.kiszka@siemens.com \
--cc=kieran@kbingham.co.uk \
--cc=lee.jones@linaro.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.griffin@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).