* [PATCH] selinux,kbuild: remove unnecessary $(hostprogs-y) from clean-files
@ 2014-04-17 2:42 Masahiro Yamada
2014-04-18 1:41 ` [PATCH] selinux, kbuild: " Paul Moore
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2014-04-17 2:42 UTC (permalink / raw)
To: linux-kbuild; +Cc: selinux, Masahiro Yamada
Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
Adding them to clean-files is redundant.
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
| 1 -
scripts/selinux/mdp/Makefile | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
--git a/scripts/selinux/genheaders/Makefile b/scripts/selinux/genheaders/Makefile
index 417b165..1d1ac51 100644
--- a/scripts/selinux/genheaders/Makefile
+++ b/scripts/selinux/genheaders/Makefile
@@ -2,4 +2,3 @@ hostprogs-y := genheaders
HOST_EXTRACFLAGS += -Isecurity/selinux/include
always := $(hostprogs-y)
-clean-files := $(hostprogs-y)
diff --git a/scripts/selinux/mdp/Makefile b/scripts/selinux/mdp/Makefile
index eb365b3..dba7eff 100644
--- a/scripts/selinux/mdp/Makefile
+++ b/scripts/selinux/mdp/Makefile
@@ -2,4 +2,4 @@ hostprogs-y := mdp
HOST_EXTRACFLAGS += -Isecurity/selinux/include
always := $(hostprogs-y)
-clean-files := $(hostprogs-y) policy.* file_contexts
+clean-files := policy.* file_contexts
--
1.8.3.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] selinux, kbuild: remove unnecessary $(hostprogs-y) from clean-files
2014-04-17 2:42 [PATCH] selinux,kbuild: remove unnecessary $(hostprogs-y) from clean-files Masahiro Yamada
@ 2014-04-18 1:41 ` Paul Moore
2014-06-03 5:47 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Paul Moore @ 2014-04-18 1:41 UTC (permalink / raw)
To: selinux, linux-kbuild; +Cc: Masahiro Yamada
On Thursday, April 17, 2014 11:42:26 AM Masahiro Yamada wrote:
> Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
> Adding them to clean-files is redundant.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>
> scripts/selinux/genheaders/Makefile | 1 -
> scripts/selinux/mdp/Makefile | 2 +-
> 2 files changed, 1 insertion(+), 2 deletions(-)
Acked-by: Paul Moore <paul@paul-moore.com>
> diff --git a/scripts/selinux/genheaders/Makefile
> b/scripts/selinux/genheaders/Makefile index 417b165..1d1ac51 100644
> --- a/scripts/selinux/genheaders/Makefile
> +++ b/scripts/selinux/genheaders/Makefile
> @@ -2,4 +2,3 @@ hostprogs-y := genheaders
> HOST_EXTRACFLAGS += -Isecurity/selinux/include
>
> always := $(hostprogs-y)
> -clean-files := $(hostprogs-y)
> diff --git a/scripts/selinux/mdp/Makefile b/scripts/selinux/mdp/Makefile
> index eb365b3..dba7eff 100644
> --- a/scripts/selinux/mdp/Makefile
> +++ b/scripts/selinux/mdp/Makefile
> @@ -2,4 +2,4 @@ hostprogs-y := mdp
> HOST_EXTRACFLAGS += -Isecurity/selinux/include
>
> always := $(hostprogs-y)
> -clean-files := $(hostprogs-y) policy.* file_contexts
> +clean-files := policy.* file_contexts
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selinux, kbuild: remove unnecessary $(hostprogs-y) from clean-files
2014-04-18 1:41 ` [PATCH] selinux, kbuild: " Paul Moore
@ 2014-06-03 5:47 ` Masahiro Yamada
2014-06-03 22:27 ` Paul Moore
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2014-06-03 5:47 UTC (permalink / raw)
To: Paul Moore; +Cc: selinux, linux-kbuild
Hi Paul Moore,
On Thu, 17 Apr 2014 21:41:53 -0400
Paul Moore <paul@paul-moore.com> wrote:
> On Thursday, April 17, 2014 11:42:26 AM Masahiro Yamada wrote:
> > Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
> > Adding them to clean-files is redundant.
> >
> > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > ---
> >
> > scripts/selinux/genheaders/Makefile | 1 -
> > scripts/selinux/mdp/Makefile | 2 +-
> > 2 files changed, 1 insertion(+), 2 deletions(-)
>
> Acked-by: Paul Moore <paul@paul-moore.com>
It looks like this patch was not included into
GIT-PULL of "SELinux patches for 3.16".
Is it possible to apply this and send another pull request?
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selinux, kbuild: remove unnecessary $(hostprogs-y) from clean-files
2014-06-03 5:47 ` Masahiro Yamada
@ 2014-06-03 22:27 ` Paul Moore
2014-06-05 7:18 ` Masahiro Yamada
0 siblings, 1 reply; 6+ messages in thread
From: Paul Moore @ 2014-06-03 22:27 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: selinux, linux-kbuild
On Tuesday, June 03, 2014 02:47:39 PM Masahiro Yamada wrote:
> Hi Paul Moore,
Hello.
> On Thu, 17 Apr 2014 21:41:53 -0400 Paul Moore <paul@paul-moore.com> wrote:
> > On Thursday, April 17, 2014 11:42:26 AM Masahiro Yamada wrote:
> > > Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
> > > Adding them to clean-files is redundant.
> > >
> > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > > ---
> > >
> > > scripts/selinux/genheaders/Makefile | 1 -
> > > scripts/selinux/mdp/Makefile | 2 +-
> > > 2 files changed, 1 insertion(+), 2 deletions(-)
> >
> > Acked-by: Paul Moore <paul@paul-moore.com>
>
> It looks like this patch was not included into
> GIT-PULL of "SELinux patches for 3.16".
>
> Is it possible to apply this and send another pull request?
My apologies, I thought the kbuild people were going to merge this patch; this
is why I sent my Acked-by instead of a note that I've merged the patch.
Considering that this patch doesn't actually fix any runtime problems and it
hasn't been in any of the different "next" trees, I think it is best to wait
until 3.17 for this patch.
I've added this patch to my queue of patches to be added to the SELinux #next
branch after the 3.16 merge window closes.
Thanks again for the patch, I'm sorry that we didn't get it merged sooner.
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selinux, kbuild: remove unnecessary $(hostprogs-y) from clean-files
2014-06-03 22:27 ` Paul Moore
@ 2014-06-05 7:18 ` Masahiro Yamada
2014-06-05 20:30 ` Paul Moore
0 siblings, 1 reply; 6+ messages in thread
From: Masahiro Yamada @ 2014-06-05 7:18 UTC (permalink / raw)
To: Paul Moore, Michal Marek; +Cc: selinux, linux-kbuild
Hi Paul, Michal,
On Tue, 03 Jun 2014 18:27:41 -0400
Paul Moore <paul@paul-moore.com> wrote:
> On Tuesday, June 03, 2014 02:47:39 PM Masahiro Yamada wrote:
> > Hi Paul Moore,
>
> Hello.
>
> > On Thu, 17 Apr 2014 21:41:53 -0400 Paul Moore <paul@paul-moore.com> wrote:
> > > On Thursday, April 17, 2014 11:42:26 AM Masahiro Yamada wrote:
> > > > Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
> > > > Adding them to clean-files is redundant.
> > > >
> > > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > > > ---
> > > >
> > > > scripts/selinux/genheaders/Makefile | 1 -
> > > > scripts/selinux/mdp/Makefile | 2 +-
> > > > 2 files changed, 1 insertion(+), 2 deletions(-)
> > >
> > > Acked-by: Paul Moore <paul@paul-moore.com>
> >
> > It looks like this patch was not included into
> > GIT-PULL of "SELinux patches for 3.16".
> >
> > Is it possible to apply this and send another pull request?
>
> My apologies, I thought the kbuild people were going to merge this patch; this
> is why I sent my Acked-by instead of a note that I've merged the patch.
> Considering that this patch doesn't actually fix any runtime problems and it
> hasn't been in any of the different "next" trees, I think it is best to wait
> until 3.17 for this patch.
>
> I've added this patch to my queue of patches to be added to the SELinux #next
> branch after the 3.16 merge window closes.
>
> Thanks again for the patch, I'm sorry that we didn't get it merged sooner.
No worries.
Michal, could you apply this patch to kbuild.git#kbuild, please?
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] selinux, kbuild: remove unnecessary $(hostprogs-y) from clean-files
2014-06-05 7:18 ` Masahiro Yamada
@ 2014-06-05 20:30 ` Paul Moore
0 siblings, 0 replies; 6+ messages in thread
From: Paul Moore @ 2014-06-05 20:30 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Michal Marek, selinux, linux-kbuild
On Thursday, June 05, 2014 04:18:23 PM Masahiro Yamada wrote:
> Hi Paul, Michal,
>
> On Tue, 03 Jun 2014 18:27:41 -0400
>
> Paul Moore <paul@paul-moore.com> wrote:
> > On Tuesday, June 03, 2014 02:47:39 PM Masahiro Yamada wrote:
> > > Hi Paul Moore,
> >
> > Hello.
> >
> > > On Thu, 17 Apr 2014 21:41:53 -0400 Paul Moore wrote:
> > > > On Thursday, April 17, 2014 11:42:26 AM Masahiro Yamada wrote:
> > > > > Files added to hostprogs-y are cleaned. (See scripts/Makefile.clean)
> > > > > Adding them to clean-files is redundant.
> > > > >
> > > > > Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > > > > ---
> > > > >
> > > > > scripts/selinux/genheaders/Makefile | 1 -
> > > > > scripts/selinux/mdp/Makefile | 2 +-
> > > > > 2 files changed, 1 insertion(+), 2 deletions(-)
> > > >
> > > > Acked-by: Paul Moore <paul@paul-moore.com>
> > >
> > > It looks like this patch was not included into
> > > GIT-PULL of "SELinux patches for 3.16".
> > >
> > > Is it possible to apply this and send another pull request?
> >
> > My apologies, I thought the kbuild people were going to merge this patch;
> > this is why I sent my Acked-by instead of a note that I've merged the
> > patch. Considering that this patch doesn't actually fix any runtime
> > problems and it hasn't been in any of the different "next" trees, I think
> > it is best to wait until 3.17 for this patch.
> >
> > I've added this patch to my queue of patches to be added to the SELinux
> > #next branch after the 3.16 merge window closes.
> >
> > Thanks again for the patch, I'm sorry that we didn't get it merged sooner.
>
> No worries.
>
> Michal, could you apply this patch to kbuild.git#kbuild, please?
As I said, it is not a problem for me to carry the patch in the SELinux tree.
--
paul moore
www.paul-moore.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-05 20:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-17 2:42 [PATCH] selinux,kbuild: remove unnecessary $(hostprogs-y) from clean-files Masahiro Yamada
2014-04-18 1:41 ` [PATCH] selinux, kbuild: " Paul Moore
2014-06-03 5:47 ` Masahiro Yamada
2014-06-03 22:27 ` Paul Moore
2014-06-05 7:18 ` Masahiro Yamada
2014-06-05 20:30 ` Paul Moore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox