From: Michal Marek <mmarek@suse.com>
To: Eugeniu Rosca <eugeniu.m.rosca@gmail.com>,
mpe@ellerman.id.au, kirill.shutemov@linux.intel.com,
naveen.n.rao@linux.vnet.ibm.com, akpm@linux-foundation.org,
sboyd@codeaurora.org, paul.gortmaker@windriver.com
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] scripts/tags.sh: Exit gracefully if *tags tool not found
Date: Mon, 25 Apr 2016 14:35:43 +0200 [thread overview]
Message-ID: <571E0F1F.8090204@suse.com> (raw)
In-Reply-To: <1461516120-5600-1-git-send-email-eugeniu.m.rosca@gmail.com>
On 2016-04-24 18:42, Eugeniu Rosca wrote:
> If the needed host utility is not found, current behavior is:
>
> $> make cscope
> GEN cscope
> ./scripts/tags.sh: line 140: cscope: command not found
> $> make gtags
> GEN gtags
> ./scripts/tags.sh: line 145: gtags: command not found
> $> make tags
> GEN tags
> xargs: ctags: No such file or directory
> sed: can't read tags: No such file or directory
> Makefile:1509: recipe for target 'tags' failed
> make: *** [tags] Error 2
> $> make TAGS
> GEN TAGS
> xargs: etags: No such file or directory
> sed: can't read TAGS: No such file or directory
> Makefile:1509: recipe for target 'TAGS' failed
> make: *** [TAGS] Error 2
>
> This patch allows to exit gracefully in such a situation:
>
> $> make cscope
> GEN cscope
> cscope - not installed?
> $> make gtags
> GEN gtags
> gtags - not installed?
> $> make tags
> GEN tags
> ctags - not installed?
> $> make TAGS
> GEN TAGS
> etags - not installed?
It should fail if it's unable to create the requested file, though.
Appending '|| exit' to the docscope/dogtags/xtags calls should suffice.
Michal
next prev parent reply other threads:[~2016-04-25 12:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 16:42 [PATCH] scripts/tags.sh: Exit gracefully if *tags tool not found Eugeniu Rosca
2016-04-25 12:35 ` Michal Marek [this message]
2016-05-15 13:44 ` Eugeniu Rosca
2016-05-16 7:06 ` Michal Marek
2016-05-16 13:37 ` [PATCH v2] scripts/tags.sh: Handle missing {c,e,g}tags/cscope utilities Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=571E0F1F.8090204@suse.com \
--to=mmarek@suse.com \
--cc=akpm@linux-foundation.org \
--cc=eugeniu.m.rosca@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=paul.gortmaker@windriver.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox