From: Michal Marek <mmarek@suse.com>
To: Eugeniu Rosca <eugeniu.m.rosca@gmail.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] scripts/tags.sh: Exit gracefully if *tags tool not found
Date: Mon, 16 May 2016 09:06:15 +0200 [thread overview]
Message-ID: <57397167.4000000@suse.com> (raw)
In-Reply-To: <20160515134413.GA14628@eugeniu-X230>
On 2016-05-15 15:44, Eugeniu Rosca wrote:
> I would kindly ask you to select one of the options provided below:
>
> OPTION 1: Append '|| exit' to the docscope/dogtags/xtags calls.
> RESULT: This produces more error messages than with the original script:
>
> $> make cscope
> GEN cscope
> ./scripts/tags.sh: line 140: cscope: command not found
> Makefile:1517: recipe for target 'cscope' failed
> make: *** [cscope] Error 127
> [...]
This is the correct behavior because a missing tool is an error.
Michal
next prev parent reply other threads:[~2016-05-16 7:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-24 16:42 [PATCH] scripts/tags.sh: Exit gracefully if *tags tool not found Eugeniu Rosca
2016-04-25 12:35 ` Michal Marek
2016-05-15 13:44 ` Eugeniu Rosca
2016-05-16 7:06 ` Michal Marek [this message]
2016-05-16 13:37 ` [PATCH v2] scripts/tags.sh: Handle missing {c,e,g}tags/cscope utilities Eugeniu Rosca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57397167.4000000@suse.com \
--to=mmarek@suse.com \
--cc=eugeniu.m.rosca@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox