From: Kieran Bingham <kieran@ksquared.org.uk>
To: linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.com>
Cc: Jan Kiszka <jan.kiszka@web.de>
Subject: Automatic dependency resolution on generated python file
Date: Tue, 24 May 2016 00:02:25 +0100 [thread overview]
Message-ID: <57438C01.6090601@bingham.xyz> (raw)
Hi Kbuild / Michal,
I've been working through a problem that Jan has reported whereby if we
modify a file included by our template for constants.py, the generated
file is not rebuilt.
The rule/cmd [0] to generate the python constants is
cmd_gen_constants_py which uses the $(CPP) with $(c_flags) to create the
output.
One benefit of this is that it already creates the $(depfile) through
the addition of the flags provided by $(c_flags), however as yet it
would seem that my efforts to understand how the $(depfile) gets
included have failed.
From what I can tell, the $(call if_changed...) rule is generating my
targets .constants.py.cmd, but the .d file is not being utilised.
By swapping $(call if_changed, ) to $(call if_changed_dep,...) I can see
that my .constants.py.cmd [1] file now has (apparently) correct
dependency rules being generated. However they still don't take actual
effect. If I 'touch/modify' one of the files I have added to the
#includes, then my target is not rebuilt (I have added
include/linux/kieran.h for testing this specifically without rebuilding
all other objects)
I can see at the bottom of my .constants.py.cmd :
scripts/gdb/linux/constants.py: $(deps_scripts/gdb/linux/constants.py)
$(deps_scripts/gdb/linux/constants.py):
which looks like it's doing the right thing to me ... except it's not
actually allowing the rule to run if a dependency is updated.
Is this failing because it is being called from the top Kbuild, as part
of making sure it is built after bounds.h, or is it because I'm not
generating from the builtin rules?
I'm hoping perhaps I've missed a stage or something obvious that will
make this automatic dependency resolution 'just-work' for recreating the
constants file.
--
Regards
Kieran Bingham
[0]
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/scripts/gdb/linux/Makefile
[1] http://paste.ubuntu.com/16645481/
next reply other threads:[~2016-05-23 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 23:02 Kieran Bingham [this message]
2016-06-20 14:50 ` Automatic dependency resolution on generated python file Michal Marek
2016-06-21 22:02 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57438C01.6090601@bingham.xyz \
--to=kieran@ksquared.org.uk \
--cc=jan.kiszka@web.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox