From: Michal Marek <mmarek@suse.com>
To: Marcin Mielniczuk <marmistrz.dev@gmail.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] Fix the Debian packaging script on systems with no codename
Date: Tue, 26 Jul 2016 23:13:34 +0200 [thread overview]
Message-ID: <5797D27E.9030903@suse.com> (raw)
In-Reply-To: <ce356ed3-4bee-6855-6906-a8bee29e7fde@gmail.com>
Dne 12.7.2016 v 21:42 Marcin Mielniczuk napsal(a):
> When calling `make deb-pkg` on a system with no codename (for example
> Arch Linux), lsb_release sometimes outputs `n/a` as the codename.
>
> This breaks dpkg-parsechangelog, which can't process the changelog
> correctly.
>
> Signed-off-by: Marcin Mielniczuk <marmistrz.dev@gmail.com>
>
> ---
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index 86e56fe..87753f5 100755
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -238,7 +238,8 @@ maintainer="$name <$email>"
> # Try to determine distribution
> if [ -n "$KDEB_CHANGELOG_DIST" ]; then
> distribution=$KDEB_CHANGELOG_DIST
> -elif distribution=$(lsb_release -cs 2>/dev/null) && [ -n
> "$distribution" ]; then
> +# In some cases lsb_release returns the codename as n/a, which breaks
> dpkg-parsechangelog
> +elif distribution=$(lsb_release -cs 2>/dev/null) && [ -n
> "$distribution" ] && [ "$distribution" != "n/a" ]; then
> : # nothing to do in this case
> else
> distribution="unstable"
Applied, but please fix your mailer to send properly formatted patches.
The easiest test is to send a patch to yourself, save it and try to
apply it with 'git am'.
Michal
prev parent reply other threads:[~2016-07-26 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 19:42 [PATCH] Fix the Debian packaging script on systems with no codename Marcin Mielniczuk
2016-07-26 21:13 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5797D27E.9030903@suse.com \
--to=mmarek@suse.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=marmistrz.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox