Re: [PATCH v2 1/2] of: support dtc compiler flags for overlays

Masahiro Yamada
2017-04-25T22:05:07Z

2017-04-25 8:05 GMT+09:00 <frowand.list@gmail.com>:
> From: Frank Rowand <frank.rowand@sony.com>
>
> The dtc compiler version that adds initial support was available
> in 4.11-rc1. Add the ability to set the dtc compiler flags needed
> by overlays.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
> ---

I know your motivation for 1/2 is overlay,
but this patch itself is more generic.
(support for per-file dtc compiler flag)

Could you reword the commit subject a little bit?

Otherwise,

Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com>

> scripts/Makefile.lib | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 0a07f9014944..0bbec480d323 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -283,6 +283,8 @@ ifeq ($(KBUILD_ENABLE_EXTRA_GCC_CHECKS),)
> DTC_FLAGS += -Wno-unit_address_vs_reg
> endif
>
> +DTC_FLAGS += $(DTC_FLAGS_$(basetarget))
> +
> # Generate an assembly file to wrap the output of the device tree compiler
> quiet_cmd_dt_S_dtb= DTB $@
> cmd_dt_S_dtb= \
> --

--
Best Regards
Masahiro Yamada