From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3052DC433B4 for ; Tue, 4 May 2021 20:52:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0FD70611AB for ; Tue, 4 May 2021 20:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231715AbhEDUxv (ORCPT ); Tue, 4 May 2021 16:53:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229542AbhEDUxv (ORCPT ); Tue, 4 May 2021 16:53:51 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BF7BC061574; Tue, 4 May 2021 13:52:55 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1le226-004AwV-RF; Tue, 04 May 2021 22:52:42 +0200 Message-ID: <58e4bd69c15fd0e0cf3de32e8ed53296d34c7e1e.camel@sipsolutions.net> Subject: Re: [PATCH 2/2] kconfig: unify cc-option and as-option From: Johannes Berg To: Masahiro Yamada Cc: Linux Kbuild mailing list , Nick Desaulniers , Arvind Sankar , Andrew Morton , Brendan Higgins , Catalin Marinas , Changbin Du , Krzysztof Kozlowski , Mauro Carvalho Chehab , Randy Dunlap , Will Deacon , linux-arm-kernel , Linux Kernel Mailing List Date: Tue, 04 May 2021 22:52:41 +0200 In-Reply-To: References: <20200614144341.1077495-1-masahiroy@kernel.org> <20200614144341.1077495-2-masahiroy@kernel.org> <70868660127bd13dcc47e94108483ff15827378c.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 (3.38.4-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-malware-bazaar: not-scanned Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Wed, 2021-05-05 at 05:46 +0900, Masahiro Yamada wrote: > >  - This commit touches scripts/Kconfig.include. >  - External module builds (M= builds) never invoke Kconfig > > Putting these two together, your claim is really odd. Hmm. > If external module builds invoke Kconfig, > your kernel is already broken. Well, it's not about the kernel, that's just the normal upstream (or perhaps distribution) kernel. Anyway, you're right, it's much simpler. The problem isn't invoking M= or something like that, that happens much later and sent me on the completely wrong track. The problem is simply doing make kernelversion to determine the version of a tree that's not writable to the user, e.g. make -C /lib/modules/$(uname -r)/build/ kernelversion Which basically also means that it's harmless, since the version is of course not affected by cc-option. johannes