From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-f195.google.com ([209.85.219.195]:35874 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbgBURwg (ORCPT ); Fri, 21 Feb 2020 12:52:36 -0500 Subject: Re: [RFC PATCH v2 1/4] scripts: Add script to generate dtb build information References: <20200221161418.20225-1-alexandre.torgue@st.com> <20200221161418.20225-2-alexandre.torgue@st.com> From: Frank Rowand Message-ID: <592e41a4-6115-474e-b6ce-eeb82f858a78@gmail.com> Date: Fri, 21 Feb 2020 11:52:34 -0600 MIME-Version: 1.0 In-Reply-To: <20200221161418.20225-2-alexandre.torgue@st.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Alexandre Torgue , robh+dt@kernel.org, Masahiro Yamada , Michal Marek , david@gibson.dropbear.id.au, sjg@chromium.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, devicetree-compiler@vger.kernel.org, Ian Lepore On 2/21/20 10:14 AM, Alexandre Torgue wrote: > This commit adds a new script to create a file (in dts file directory) with > some information (date, Linux version, user). This file could then be used > to populate "build-info" property in every dts file that would use this > build information: > > Example: > > / { > ... > build-info = /incbin/("dtb-build.txt"); s/.txt/.dtsi/ and same wherever the file name is used. > ... > }; > > Signed-off-by: Alexandre Torgue > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index bae62549e3d2..a5af84ef4ffc 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -246,6 +246,7 @@ quiet_cmd_gzip = GZIP $@ > # DTC > # --------------------------------------------------------------------------- > DTC ?= $(objtree)/scripts/dtc/dtc > +DTB_GEN_INFO ?= $(objtree)/scripts/gen_dtb_build_info.sh > > # Disable noisy checks by default > ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),) > @@ -286,6 +287,7 @@ $(obj)/%.dtb.S: $(obj)/%.dtb FORCE > > quiet_cmd_dtc = DTC $@ > cmd_dtc = mkdir -p $(dir ${dtc-tmp}) ; \ > + $(DTB_GEN_INFO) $(src) ; \ > $(HOSTCC) -E $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \ > $(DTC) -O $(2) -o $@ -b 0 \ > $(addprefix -i,$(dir $<) $(DTC_INCLUDE)) $(DTC_FLAGS) \ > diff --git a/scripts/gen_dtb_build_info.sh b/scripts/gen_dtb_build_info.sh > new file mode 100755 > index 000000000000..0cd8bd98e410 > --- /dev/null > +++ b/scripts/gen_dtb_build_info.sh > @@ -0,0 +1,10 @@ > +#!/bin/bash > +# SPDX-License-Identifier: GPL-2.0 > + > +set -o nounset > + > +DTB_DIR=$1 > +DTB_COMPILE_BY=$(whoami | sed 's/\\/\\\\/') > +DTB_INFO="From Linux $KERNELRELEASE by $DTB_COMPILE_BY the $(date).\0" I would remove the filler words "From", "by", "the", and the trailing period ('.'). You might consider using a format more like the Linux kernel version line, which puts parenthesis around the compiled by info. -Frank > + > +printf "$DTB_INFO" > "$DTB_DIR/dtb-build.txt" >