From: Andrew Donnellan <ajd@linux.ibm.com>
To: Benjamin Gray <bgray@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 1/2] initramfs: Check negative timestamp to prevent broken cpio archive
Date: Wed, 22 Mar 2023 15:29:07 +1100 [thread overview]
Message-ID: <5d909e0b1a9155112feb72b1f99c9fc4fc2d4263.camel@linux.ibm.com> (raw)
In-Reply-To: <20230320040839.660475-1-bgray@linux.ibm.com>
On Mon, 2023-03-20 at 15:08 +1100, Benjamin Gray wrote:
> Similar to commit 4c9d410f32b3 ("initramfs: Check timestamp to
> prevent
> broken cpio archive"), except asserts that the timestamp is
> non-negative. This can happen when the KBUILD_BUILD_TIMESTAMP is a
> value
> before UNIX epoch, which may be set when making reproducible builds
> that
> don't want to look like they use a valid date.
>
> While support for dates before 1970 might not be supported, this is
> more
> about preventing undetected CPIO corruption. The printf's use a
> minimum
> length format specifier, and will happily make the field longer than
> 8
> characters if they need to.
>
> Signed-off-by: Benjamin Gray <bgray@linux.ibm.com>
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
Tested-by: Andrew Donnellan <ajd@linux.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2023-03-22 4:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 4:08 [PATCH 1/2] initramfs: Check negative timestamp to prevent broken cpio archive Benjamin Gray
2023-03-20 4:08 ` [PATCH 2/2] initramfs: Encode dependency on KBUILD_BUILD_TIMESTAMP Benjamin Gray
2023-03-22 5:25 ` Andrew Donnellan
2023-04-16 4:06 ` Masahiro Yamada
2023-06-06 4:14 ` Masahiro Yamada
2023-06-06 6:18 ` Benjamin Gray
2023-03-22 4:29 ` Andrew Donnellan [this message]
2023-04-16 8:46 ` [PATCH 1/2] initramfs: Check negative timestamp to prevent broken cpio archive Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d909e0b1a9155112feb72b1f99c9fc4fc2d4263.camel@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=bgray@linux.ibm.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox