From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.kundenserver.de ([212.227.17.24]:59684 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751233AbcAMUqJ (ORCPT ); Wed, 13 Jan 2016 15:46:09 -0500 From: Arnd Bergmann Subject: Re: [PATCH] logfs: clarify MTD dependency Date: Wed, 13 Jan 2016 21:45:05 +0100 Message-ID: <6116283.ubGS0D0e49@wuerfel> In-Reply-To: <20160113123918.544497b48bf4c03591c75747@linux-foundation.org> References: <5776957.XLg438VUOx@wuerfel> <20160113123918.544497b48bf4c03591c75747@linux-foundation.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Andrew Morton Cc: mmarek@suse.com, Peter Chen , Randy Dunlap , Joern Engel , Prasad Joshi , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Wednesday 13 January 2016 12:39:18 Andrew Morton wrote: > > Randy's "logfs: fix logfs build errors and dependencies" is an > only-in-mm thing. So it would make sense to combine the two patches > into a single one and to give that an appropriate changelog. > > How does this look? (Primary author was chosen randomly) > > > From: Arnd Bergmann > Subject: logfs: fix logfs build errors and dependencies > > Fix build errors that happen when CONFIG_LOGFS=y and CONFIG_MTD=m: > > fs/built-in.o: In function `logfs_mount': > super.c:(.text+0x92a6f): undefined reference to `logfs_get_sb_mtd' > fs/built-in.o: In function `logfs_get_sb_bdev': > (.text+0x93530): undefined reference to `logfs_get_sb_mtd' > > This patch avoids the error by changing the dependencies of > logfs in a way that we can no longer configure logfs as built-in > when the MTD core is a loadable module, while leaving the > dependency to require at least one of MTD or BLOCK to be > enabled. > > Signed-off-by: Arnd Bergmann > Signed-off-by: Randy Dunlap > Cc: Michal Marek > Cc: Peter Chen > Cc: Randy Dunlap > Cc: Joern Engel > Cc: Prasad Joshi > Signed-off-by: Andrew Morton > Looks good, thanks! Arnd