Re: [PATCH] Input: amimouse - Mark driver struct with __refdata to prevent section mismatch

Dmitry Torokhov
2024-04-30T20:59:09Z

Hi Uwe,

On Mon, Apr 29, 2024 at 10:29:41PM +0200, Uwe Kleine-König wrote:
> Hello Dmitry,
>
> On Mon, Apr 15, 2024 at 04:34:53PM +0200, Uwe Kleine-König wrote:
> > On Fri, Mar 29, 2024 at 10:54:38PM +0100, Uwe Kleine-König wrote:
> > > As described in the added code comment, a reference to .exit.text is ok
> > > for drivers registered via module_platform_driver_probe(). Make this
> > > explicit to prevent the following section mismatch warning
> > >
> > > WARNING: modpost: drivers/input/mouse/amimouse: section mismatch in reference: amimouse_driver+0x8 (section: .data) -> amimouse_remove (section: .exit.text)
> > >
> > > that triggers on an allmodconfig W=1 build.
> > >
> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >
> > I'd like to enable these warnings even for W=0 builds, so it would be
> > great to get it into the main line soon.
> >
> > If you apply it, please notice that I fat-fingered the parameters to git
> > send-email and it was sent in a thread. So (assuming you're using b4)
> > you'd need:
> >
> > b4 am -P _ -v1 2e3783106bf6bd9a7bdeb12b706378fb16316471.1711748999.git.u.kleine-koenig@pengutronix.de
>
> Do you have this patch still on your radar? I guess it's to late to get
> it into v6.9 now, but do you plan to apply it for v6.10-rc1?

I'll get it into 6.9, it is not controversial.

Thanks.

--
Dmitry