From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0BF61C689F for ; Tue, 1 Oct 2024 14:08:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727791694; cv=none; b=cnKy03OQUFDwIhZf4ylbKpBSps58OSp6B7Rrz+Nc5TewZVbE/FcNX8xACt5XPO9O6C87YRm1nkiZQEBhUqericXDZI83V1qma9sVhBtvEvOhgMLvqnsesH2DKmMwfK2BpVmP18Gxw0aT4heDawoAoWm4ZgzYDmXNB6nDfjSj/s4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727791694; c=relaxed/simple; bh=BomYIPLYM5BI9NRjik6sw8fZV0AIRi6SbLd8MV+XBg4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ob3GAOLoVs7zqfDDauMzy8pv0wyEEphZYFVxdTzN9E3v+7CLOP7kEuIl0FRQt4jdwcLThOIf+T04rMFo9AgTsXNZxC/dXZyr9QXxNUnLNp+AFgqvf4W8jdcfTXYI7c/Xy9ChNssJzbvRUe5hFh9ROVgv12QeDHW/lVke9PIcF4Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=P6QjCZOo; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="P6QjCZOo" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a910860e4dcso52506166b.3 for ; Tue, 01 Oct 2024 07:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1727791690; x=1728396490; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tuxy9H0NBJRRS74N6JfR6UfMk8p+Pp8gRC0GHyWlDK4=; b=P6QjCZOocYX/TymCID2swxqbhqENPZNlKJn29SPinWuWswEm/05d0pUZRqstr8xOjF HbVCtzjkJAasYQRyC8HuWieVQtDNks1UEB47MO0FAYRX+WfN1PYv8u0/Yt/Uh3iqnrPJ dfaamCSO+U4gjESZvVnNlNx+cLmCvpOeF4HLtY8adNl+HUGGJXZ4vectA/An/V3v3VJr 4nfAgbCRfPh+9xxRL9ScNK8SOSZVXfgVqU1kwn6S0iLGouGcj20chCVEiHCIgvORWbVR miXw+OuwmsJbzrRDK2doafhLfJ8yzv6zEzMIP1FYXTiouyODmK26JqH8dTEMtNgMOYB8 0I4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727791690; x=1728396490; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tuxy9H0NBJRRS74N6JfR6UfMk8p+Pp8gRC0GHyWlDK4=; b=lWpoT9gYJYuLNlfM+vMRwMDDxkmO7kXfm7LMcok3xnqg0JVnbdRIReOmLJ8ncviFKn u/lsa1vqqqGZ6x3raXcP3cnRdGLxAQ3HEwxGDpGIvvUHzYb2jWAk4VMORhPKoZeLpisu B7lR1ivttgeKoh5MuZ7jDKB0v7XvqpcVaRCXsuW6JtHrxL7ftL4DQVXP/EmIa94re+5W dMFKa1+bETXPsnMUDQ0722GUprGW7lQn+xSBrvjelQJb/LVdLwfu81GbqFJtRzK/aoiI y77+rrxLyId9vwPe0AJjdZ2gtZosSnnsT61Y5tN+dPT6megOO3gQigPJbkZZIqXBYbzU 4dRQ== X-Forwarded-Encrypted: i=1; AJvYcCWlltiAhnqCG9IeWrjK7RTyugi3AeSJfX9/hT2TjUPQbaTsI6I4BegiMRT/PshW9373jH/0RIfZdrjkU/s=@vger.kernel.org X-Gm-Message-State: AOJu0YwVLhsCJhiee8OpHnRXhjh5xuWCFb6pSVjewsw53FHDbOz8ohz6 FWAkfxIEyDy8JBJ+aLAlbVSsDfobBJNyG5aYZvrgzJFqRgouI9aBXcInnI5oqVU= X-Google-Smtp-Source: AGHT+IGtCaqW1iYqY0ka6u8nR5cuIhkkzcw74TSNyxlTUt01ZQat8MsCjI7LNjjDnGVwTilgDCrZfQ== X-Received: by 2002:a17:907:7ba3:b0:a77:eb34:3b49 with SMTP id a640c23a62f3a-a93c492a5d1mr1614882866b.37.1727791690027; Tue, 01 Oct 2024 07:08:10 -0700 (PDT) Received: from [10.100.51.161] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a93c2775c22sm715531166b.20.2024.10.01.07.08.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Oct 2024 07:08:09 -0700 (PDT) Message-ID: <6d0a36f0-6534-4301-bc4e-929a2e779e1c@suse.com> Date: Tue, 1 Oct 2024 16:08:08 +0200 Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 05/20] gendwarfksyms: Expand base_type To: Sami Tolvanen Cc: Masahiro Yamada , Luis Chamberlain , Miguel Ojeda , Greg Kroah-Hartman , Matthew Maurer , Alex Gaynor , Wedson Almeida Filho , Gary Guo , Petr Pavlu , Neal Gompa , Hector Martin , Janne Grunau , Miroslav Benes , Asahi Linux , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, rust-for-linux@vger.kernel.org References: <20240923181846.549877-22-samitolvanen@google.com> <20240923181846.549877-27-samitolvanen@google.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20240923181846.549877-27-samitolvanen@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 9/23/24 20:18, Sami Tolvanen wrote: > Start making gendwarfksyms more useful by adding support for > expanding DW_TAG_base_type types and basic DWARF attributes. > > Example: > > $ echo loops_per_jiffy | \ > scripts/gendwarfksyms/gendwarfksyms \ > --debug --dump-dies vmlinux.o > ... > gendwarfksyms: process_symbol: loops_per_jiffy > variable base_type unsigned long byte_size(8) encoding(7) > ... > > Signed-off-by: Sami Tolvanen > [...] Looks ok to me, feel free to add: Reviewed-by: Petr Pavlu -- Thanks, Petr