From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A458F18DB1C for ; Mon, 17 Feb 2025 10:27:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739788064; cv=none; b=P9rHGLjgiBU7VLSjqVRYQmyhQo9zSxdId62bQkQAyDyO2SfOmxZqFp7zct1a8wy1XaFt1kHH8MK6m+nFOC5fSqKtD12Y0du6TJ61t2zaRd9KvQIAVAaJSMeaPxhMlgbAtscYa4WBemePYBbefo2WN/IebeDyr+Qm3eX9IkFV7FY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739788064; c=relaxed/simple; bh=EK+112KzZRYcpPHXSL1MB9m3HLKRqSwNI05I9TJltSw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G8BTe0RJhEXkwXNXU1yoXaBaZtl42oCPomMtsHs5pqS7tT1IXoeQvbdViO+AAdGM3LYVliHXA2hEfTTZ9shsEAfiRZwiAC871AGji8zNgj4NWKKxzwCTaF5j1Ku7SrKOMJr6BYz7Q8XFaeVfsK0ivOLOyaI24DWm1iV2XP2/f1Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=aKdVlrzk; arc=none smtp.client-ip=209.85.208.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="aKdVlrzk" Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5ded1395213so6496140a12.2 for ; Mon, 17 Feb 2025 02:27:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1739788061; x=1740392861; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aUsyjtdwJudOrq2BVYPPPLmXtZGANjt6rB5YxXGDCHQ=; b=aKdVlrzktnUkea5HDMMTnv4ZhtKw1+cqiE2E7M/JLSD9dR1je6nfLe2j2xbFdPKUqM 3bX9gCAsdlslWcmwZ4MWquO/rzZjSjbtzutHhQT3MSFvuG3rgIcKmS6luCa7Js+op8Jk 7o5ZJ90RwwoC1O6PT9CuXGfxrkugtmxsnj+3HCq0lD4cy9GqvIoiK09QGSLZ2eE44FtZ I4bTF1qy/Powhb6dEiItCyRjdDDHnutTYmqReZH/Zg2KeF7/8nJPL2DcFpDwZnlhWRHK P31pQEMDuFWtXqk+LJkbqWC1fIYDPkBQpwFrXzuiWVarEsZEFPTdt8h7T1stS2K27QEa YsCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739788061; x=1740392861; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aUsyjtdwJudOrq2BVYPPPLmXtZGANjt6rB5YxXGDCHQ=; b=p7U5sHEOknCVOKAVjoTthcxIofNh7V1EFIH6smbFOPhuB3GUOEm2ISG+Hbr6W25Zxc YPcOuf67zUpndDQazIcxqTzz3lBJUJsteeKVgY6CAHihpFVnZUkTkDgLGK/NyPlbR8p5 qdEBplCOLI5kgrHCw3h1bZtHnACGcSbrr2IoiDLshyYYPow23pCKJsunmp4LeI7/o3wR xZeWbvPL1GJRrhbu0lgIqkCv7gAQcDD1G3dNwi4irsXkY6aAoeZAPdnFqfnWCJkqM78N DE7iHrwlP3mjiWCbfQX04aD9Auy0o8Z1LwBD9nl1CzWgv/f6yD/uCXvaZlt/1xGfctdD t4hw== X-Forwarded-Encrypted: i=1; AJvYcCXzbHihyOdEYyi3B+cwEWPf+mccStzM9yN9W1MNxJSzaKpmpV7Gl/XQVWVz3mvQa4CgDyJu96iQ6NTdsh0=@vger.kernel.org X-Gm-Message-State: AOJu0YxKqhynQfx0L0qa6cdpcsz0EGVNX51BQO8WDlVdiccIouUNJRU0 R4rNSvq6kmsV/dKUj1CYNtPpWwaNBdFSTNAWSBt7yqmzNSSHcB2NDsTTe3UxMcY= X-Gm-Gg: ASbGncvX6MQ2x+oFQKqKh/ltgxW/cVUo5SFKttKBrebCjnarw9uZmQRdDgbracIUEbB 2QdDUbc8NJVWKrDse/PPScwqjQZZLz7unhoNeETS7mx2dmCyTWHncfmIVYcXiOReMU7mXrGE3J2 P82pc9MwTiDpr0WTRRVK/TDV78ZNkR4X4aedngl+vUh/gC7Q/cMigsGwt8ZRPeESovtC5wnXTjx FinW5uDF8GhoEG91J5OewDJ/8pdSDL4bZiFwpPFAI9IiWk/WfrRy5+A2ZvTelun69WjWKtAlfiV GI7S4fr7dw1k997XKQw= X-Google-Smtp-Source: AGHT+IE+SP8oa6aMi/Tazd2StJ2PQQ1xliUBBqg3M956avxBmZaXfoRNcJbotwH3UYKzBBxyZyxzjA== X-Received: by 2002:a17:907:80b:b0:aba:519b:f774 with SMTP id a640c23a62f3a-abb70df5d81mr943214466b.52.1739788060920; Mon, 17 Feb 2025 02:27:40 -0800 (PST) Received: from [10.100.51.161] ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-abb8b1767e8sm309892566b.174.2025.02.17.02.27.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Feb 2025 02:27:40 -0800 (PST) Message-ID: <7798e5f7-11bb-4ef0-8956-1208827cb097@suse.com> Date: Mon, 17 Feb 2025 11:27:39 +0100 Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 6/6] rust: add parameter support to the `module!` macro To: Andreas Hindborg Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Luis Chamberlain , Trevor Gross , Adam Bratschi-Kaye , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, Sami Tolvanen , Daniel Gomez , Simona Vetter , Greg KH , linux-modules@vger.kernel.org References: <20250211-module-params-v3-v6-0-24b297ddc43d@kernel.org> <20250211-module-params-v3-v6-6-24b297ddc43d@kernel.org> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20250211-module-params-v3-v6-6-24b297ddc43d@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/11/25 16:57, Andreas Hindborg wrote: > This patch includes changes required for Rust kernel modules to utilize > module parameters. This code implements read only support for integer > types without `sysfs` support. > > Signed-off-by: Andreas Hindborg For what it's worth, this looks reasonable to me from the modules perspective. Acked-by: Petr Pavlu # from modules perspective -- Thanks, Petr