From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9C90C4338F for ; Tue, 17 Aug 2021 02:08:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A2F9160FA0 for ; Tue, 17 Aug 2021 02:08:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234047AbhHQCIr (ORCPT ); Mon, 16 Aug 2021 22:08:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:43564 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236138AbhHQCIq (ORCPT ); Mon, 16 Aug 2021 22:08:46 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E012360F55; Tue, 17 Aug 2021 02:08:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629166093; bh=4DKsW+Y254h0LIfiIDGc5btd1MDbS1Uf8FdQxVoju98=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=sbdjdovsRi4sae2ELAiVUJV2tZURxq/e3Je9n7V0XpGmJVgnQVwckdNgF3S6aue4j PzCFObXebIbBhBU6lEo9OteCsjL5BgaOCoHYthG+gSSOCZ/cePbFm1kFQ2XO4v0uGL OrkjslGUEfVUPmTTQYFe7Q89NNH78BEPfJMs2PMYIVNSfxgLQoxNYYelQ/gN99pRfP XiqTmIgCOLPSLbo4jgLc9IjwJOuEQEN1altCeWs3vwIxHrX3S/YDdClO7yW4wGfInr Vw024cpmGcFHxHIq1iVudM4/CxLGV60ZoQhFLhoHk89zevJX5294SI9Rs30+MkmxG3 4Iyp6Lo+2bwFA== Subject: Re: [PATCH 5/7] x86: remove cc-option-yn test for -mtune= To: Nick Desaulniers , Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, clang-built-linux@googlegroups.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , x86@kernel.org References: <20210817002109.2736222-1-ndesaulniers@google.com> <20210817002109.2736222-6-ndesaulniers@google.com> From: Nathan Chancellor Message-ID: <7a39afcf-363b-9ee1-00d1-5adc9def231d@kernel.org> Date: Mon, 16 Aug 2021 19:08:11 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210817002109.2736222-6-ndesaulniers@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On 8/16/2021 5:21 PM, 'Nick Desaulniers' via Clang Built Linux wrote: > As noted in the comment, -mtune= has been supported since GCC 3.4. The > minimum required version of GCC to build the kernel (as specified in > Documentation/process/changes.rst) is GCC 4.9. > > tune is not immediately expanded. Instead it defines a macro that will > test via cc-option later values for -mtune=. But we can skip the test > whether to use -mtune= vs. -mcpu=. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: Borislav Petkov > Cc: H. Peter Anvin > Cc: x86@kernel.org > Signed-off-by: Nick Desaulniers Yay for removing stale checks! Reviewed-by: Nathan Chancellor > --- > arch/x86/Makefile_32.cpu | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/x86/Makefile_32.cpu b/arch/x86/Makefile_32.cpu > index cd3056759880..e7355f8b51c2 100644 > --- a/arch/x86/Makefile_32.cpu > +++ b/arch/x86/Makefile_32.cpu > @@ -2,13 +2,7 @@ > # CPU tuning section - shared with UML. > # Must change only cflags-y (or [yn]), not CFLAGS! That makes a difference for UML. > > -#-mtune exists since gcc 3.4 > -HAS_MTUNE := $(call cc-option-yn, -mtune=i386) > -ifeq ($(HAS_MTUNE),y) > tune = $(call cc-option,-mtune=$(1),$(2)) > -else > -tune = $(call cc-option,-mcpu=$(1),$(2)) > -endif > > cflags-$(CONFIG_M486SX) += -march=i486 > cflags-$(CONFIG_M486) += -march=i486 >