Re: [RFC v3 12/12] Simplify dependencies for MODULE_SIG_KEY_TYPE_RSA & MODULE_SIG_KEY_TYPE_ECDSA

Luis Chamberlain
2021-10-22T17:03:47Z

On Fri, Oct 22, 2021 at 03:48:55PM +0200, Thorsten Berger wrote:
> Co-developed-by: Patrick Franz <deltaone@debian.org>
> Signed-off-by: Patrick Franz <deltaone@debian.org>
> Co-developed-by: Ibrahim Fayaz <phayax@gmail.com>
> Signed-off-by: Ibrahim Fayaz <phayax@gmail.com>
> Reviewed-by: Luis Chamberlain <mcgrof@suse.com>
> Tested-by: Evgeny Groshev <eugene.groshev@gmail.com>
> Suggested-by: Sarah Nadi <nadi@ualberta.ca>
> Suggested-by: Thorsten Berger <thorsten.berger@rub.de>
> Signed-off-by: Thorsten Berger <thorsten.berger@rub.de>
>
> This choice group presents a problem as it is possible that no option can be
> chosen when the choice group is visible.
> Every option contains additional dependencies compared to the group. Hence it
> is possible that the group is visible, but not a single option can be chosen
> as these additional dependencies are not satisfied.
> By moving these additional dependencies from the options into the group, a
> visible choice group ensures that both options can be chosen.
>

Re-arrange so that description goes first and then you put the SOB tags
/ Reviewed-by tags.

Also, be sure to use ./scripts/get_maintainer.pl foo.patch, and when you
send your patches on v4, please add all the emails you collect to the
target audience. This patch in particular should be reviewed by folks
who maintain the file being changed. Please also cc linux-kernel@vger.kernel.org
on your patch set.

Luis