From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Michal Marek <mmarek@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] tags: honor COMPILED_SOURCE with apart output directory
Date: Tue, 06 Dec 2016 12:54:54 +0100 [thread overview]
Message-ID: <8737i12rxt.fsf@belgarion.home> (raw)
In-Reply-To: <1476736079-11963-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Mon, 17 Oct 2016 22:27:59 +0200")
Robert Jarzmik <robert.jarzmik@free.fr> writes:
> When the kernel is compiled with an "O=" argument, the object files are
> not necessarily in the source tree, and more probably in another tree.
>
> In this situation, the current used check doesn't work, and
> COMPILED_SOURCE tags is broken with O= builds.
>
> This patch fixes it by looking for object files both in source tree and
> potential destination tree.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Hi Marek, ping about this patch ?
Cheers.
--
Robert
PS: The patch content top-posted
> ---
> scripts/tags.sh | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index b3775a9604ea..c0220fa05617 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -106,7 +106,9 @@ all_compiled_sources()
> case "$i" in
> *.[cS])
> j=${i/\.[cS]/\.o}
> - if [ -e $j ]; then
> + k=${i/"$tree"/"$O"\/}
> + k=${k/\.[cS]/\.o}
> + if [ -e $j -o -e "$k" ]; then
> echo $i
> fi
> ;;
next prev parent reply other threads:[~2016-12-06 12:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 20:27 [PATCH] tags: honor COMPILED_SOURCE with apart output directory Robert Jarzmik
2016-12-06 11:54 ` Robert Jarzmik [this message]
2016-12-11 21:20 ` Michal Marek
2016-12-12 17:13 ` Robert Jarzmik
2016-12-12 20:41 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8737i12rxt.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox