Linux kbuild/kconfig development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Askar Safin <safinaskar@gmail.com>
Cc: "Takashi Iwai" <tiwai@suse.de>,
	Dell.Client.Kernel@dell.com, amadeuszx.slawinski@linux.intel.com,
	baojun.xu@ti.com, bo.liu@senarytech.com,
	cezary.rojewski@intel.com, kai.vehmanen@linux.intel.com,
	kailang@realtek.com, linux-sound@vger.kernel.org,
	patches@opensource.cirrus.com, regressions@lists.linux.dev,
	rf@opensource.cirrus.com, "Nicolas Schier" <nsc@kernel.org>,
	linux-kbuild@vger.kernel.org,
	"Masahiro Yamada" <masahiroy@kernel.org>,
	"Nathan Chancellor" <nathan@kernel.org>,
	miguel.ojeda.sandonis@gmail.com, ojeda@kernel.org,
	sam@gentoo.org,
	"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
	"Daniel Xu" <dxu@dxuuu.xyz>
Subject: Re: [REGRESSION][BISECTED] My audio broke (was: [PATCH 05/27] ALSA: hda: Move controller drivers into sound/hda/controllers directory)
Date: Tue, 09 Dec 2025 08:57:46 +0100	[thread overview]
Message-ID: <875xagt7d1.wl-tiwai@suse.de> (raw)
In-Reply-To: <CAPnZJGBq=q2iW9gMEv9U9LCKJ6f6Uu7Z3QrDCw6SdRGL0sAKVQ@mail.gmail.com>

On Sat, 06 Dec 2025 22:39:52 +0100,
Askar Safin wrote:
> 
> On Wed, Dec 3, 2025 at 12:42 PM Takashi Iwai <tiwai@suse.de> wrote:
> > A rather hackish fix would be something like below.  Instead of
> 
> I tested. This patch works. Thank you!
> Tested-by: Askar Safin <safinaskar@gmail.com>

Thanks for testing!

On the second thought, a better fix would be just to change the
default fallback from ANY to LEGACY, so a oneliner change like below.
Could you test it instead of the previous one?

It was set to ANY as we assumed that all drivers should cover the
devices generally, but in the end, SOF or AVS need specific firmware
files, hence it doesn't make sense to bind to them if specific kconfig
is enabled.


Takashi

-- 8< --
--- a/sound/hda/core/intel-dsp-config.c
+++ b/sound/hda/core/intel-dsp-config.c
@@ -718,7 +718,7 @@ int snd_intel_dsp_driver_probe(struct pci_dev *pci)
 	/* find the configuration for the specific device */
 	cfg = snd_intel_dsp_find_config(pci, config_table, ARRAY_SIZE(config_table));
 	if (!cfg)
-		return SND_INTEL_DSP_DRIVER_ANY;
+		return SND_INTEL_DSP_DRIVER_LEGACY;
 
 	if (cfg->flags & FLAG_SOF) {
 		if (cfg->flags & FLAG_SOF_ONLY_IF_SOUNDWIRE &&

  reply	other threads:[~2025-12-09  7:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87o6q8l68r.wl-tiwai@suse.de>
     [not found] ` <20251015145749.2572-1-safinaskar@gmail.com>
     [not found]   ` <878qhckxc5.wl-tiwai@suse.de>
     [not found]     ` <CAPnZJGDeCkqqUpEh0SBfwvsxfMp9ZDXqvhrC1s9zRp6jX+Fvnw@mail.gmail.com>
     [not found]       ` <875xcgkvnw.wl-tiwai@suse.de>
     [not found]         ` <CAPnZJGDmCnKPz2eygwDjQGXZWVctGyJxV+OeFSLLeZPOCEvvbA@mail.gmail.com>
2025-10-16  4:50           ` [REGRESSION][BISECTED] My audio broke (was: [PATCH 05/27] ALSA: hda: Move controller drivers into sound/hda/controllers directory) Askar Safin
2025-10-16  6:03             ` Askar Safin
2025-10-16  9:52               ` Takashi Iwai
2025-10-28 12:05                 ` Takashi Iwai
2025-10-28 13:03                   ` Askar Safin
2025-10-29 12:23                   ` Askar Safin
2025-12-02 19:21                 ` Askar Safin
2025-12-03  9:42                   ` Takashi Iwai
2025-12-06 21:39                     ` Askar Safin
2025-12-09  7:57                       ` Takashi Iwai [this message]
2025-12-09  9:27                         ` Takashi Iwai
2025-12-10  1:45                           ` Askar Safin
2025-12-10 13:00                             ` Takashi Iwai
2025-12-10 13:55                               ` Thorsten Leemhuis
2025-12-11 18:11                               ` Askar Safin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875xagt7d1.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=Dell.Client.Kernel@dell.com \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=baojun.xu@ti.com \
    --cc=bo.liu@senarytech.com \
    --cc=cezary.rojewski@intel.com \
    --cc=dxu@dxuuu.xyz \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=kailang@realtek.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=nathan@kernel.org \
    --cc=nsc@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=patches@opensource.cirrus.com \
    --cc=regressions@lists.linux.dev \
    --cc=rf@opensource.cirrus.com \
    --cc=safinaskar@gmail.com \
    --cc=sam@gentoo.org \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox