From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org ([103.22.144.67]:46881 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753092AbaHSOCt (ORCPT ); Tue, 19 Aug 2014 10:02:49 -0400 From: Rusty Russell Subject: Re: [PATCH 3/3] modsign: lookup lines ending in .ko in .mod files In-Reply-To: <1408215016-1848-4-git-send-email-beber@meleeweb.net> References: <1408215016-1848-1-git-send-email-beber@meleeweb.net> <1408215016-1848-4-git-send-email-beber@meleeweb.net> Date: Tue, 19 Aug 2014 06:30:10 +0930 Message-ID: <8761hp8qed.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Bertrand Jacquin , linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Willy Tarreau , David Woodhouse Bertrand Jacquin writes: > This does the same as commit ef591a5 (scripts/Makefile.modpost: error > in finding modules from .mod files), but for scripts/Makefile.modsign > > Maybe we should also apply to Makefile.modsign and Makefile.modinst > the change applied to Makefile.modpost by commit ea4054a (modpost: > handle huge numbers of modules) ? Good question. David Woodhose cc'd... Cheers, Rusty. > Reviewed-by: Willy Tarreau > Signed-off-by: Bertrand Jacquin > --- > scripts/Makefile.modsign | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/Makefile.modsign b/scripts/Makefile.modsign > index abfda62..b6ac708 100644 > --- a/scripts/Makefile.modsign > +++ b/scripts/Makefile.modsign > @@ -7,7 +7,7 @@ __modsign: > > include scripts/Kbuild.include > > -__modules := $(sort $(shell grep -h '\.ko' /dev/null $(wildcard $(MODVERDIR)/*.mod))) > +__modules := $(sort $(shell grep -h '\.ko$$' /dev/null $(wildcard $(MODVERDIR)/*.mod))) > modules := $(patsubst %.o,%.ko,$(wildcard $(__modules:.ko=.o))) > > PHONY += $(modules) > -- > 2.0.4