[PATCH] drm/i915: select CRC32

[PATCH] drm/i915: select CRC32

[Nicholas Piggin]

kbuild test robot found a build failure when building with thin
archives:

http://marc.info/?l=linux-kbuild&m=149802285009737&w=2

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
 drivers/gpu/drm/i915/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index a5cd5dacf055..e9e64e8e9765 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -21,6 +21,7 @@ config DRM_I915
 	select ACPI_BUTTON if ACPI
 	select SYNC_FILE
 	select IOSF_MBI
+	select CRC32
 	help
 	  Choose this option if you have a system that has "Intel Graphics
 	  Media Accelerator" or "HD Graphics" integrated graphics,
-- 
2.11.0

Re: [PATCH] drm/i915: select CRC32

[Daniel Vetter]

On Wed, Jun 21, 2017 at 04:34:20PM +1000, Nicholas Piggin wrote:
> kbuild test robot found a build failure when building with thin
> archives:
> 
> http://marc.info/?l=linux-kbuild&m=149802285009737&w=2
> 
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>

Pushed to drm-intel for 4.14, thanks.
-Daniel

> ---
>  drivers/gpu/drm/i915/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index a5cd5dacf055..e9e64e8e9765 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -21,6 +21,7 @@ config DRM_I915
>  	select ACPI_BUTTON if ACPI
>  	select SYNC_FILE
>  	select IOSF_MBI
> +	select CRC32
>  	help
>  	  Choose this option if you have a system that has "Intel Graphics
>  	  Media Accelerator" or "HD Graphics" integrated graphics,
> -- 
> 2.11.0
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [PATCH] drm/i915: select CRC32

[Chris Wilson]

Quoting Daniel Vetter (2017-06-21 10:13:41)
> On Wed, Jun 21, 2017 at 04:34:20PM +1000, Nicholas Piggin wrote:
> > kbuild test robot found a build failure when building with thin
> > archives:
> > 
> > http://marc.info/?l=linux-kbuild&m=149802285009737&w=2
> > 
> > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
> 
> Pushed to drm-intel for 4.14, thanks.

Probably deserves to be in fixes if we identify what introduced the CRC
dep. mst-dp? pipe crc?
-Chris

Re: [PATCH] drm/i915: select CRC32

[Nicholas Piggin]

On Wed, 21 Jun 2017 10:15:56 +0100
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> Quoting Daniel Vetter (2017-06-21 10:13:41)
> > On Wed, Jun 21, 2017 at 04:34:20PM +1000, Nicholas Piggin wrote:  
> > > kbuild test robot found a build failure when building with thin
> > > archives:
> > > 
> > > http://marc.info/?l=linux-kbuild&m=149802285009737&w=2
> > > 
> > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>  
> > 
> > Pushed to drm-intel for 4.14, thanks.  
> 
> Probably deserves to be in fixes if we identify what introduced the CRC
> dep. mst-dp? pipe crc?

Looks like

579cea5f3 ("drm/i915/gvt: golden virtual HW state management")

Thanks,
Nick

Re: [PATCH] drm/i915: select CRC32

[Jani Nikula]

On Wed, 21 Jun 2017, Nicholas Piggin <npiggin@gmail.com> wrote:
> On Wed, 21 Jun 2017 10:15:56 +0100
> Chris Wilson <chris@chris-wilson.co.uk> wrote:
>
>> Quoting Daniel Vetter (2017-06-21 10:13:41)
>> > On Wed, Jun 21, 2017 at 04:34:20PM +1000, Nicholas Piggin wrote:  
>> > > kbuild test robot found a build failure when building with thin
>> > > archives:
>> > > 
>> > > http://marc.info/?l=linux-kbuild&m=149802285009737&w=2
>> > > 
>> > > Signed-off-by: Nicholas Piggin <npiggin@gmail.com>  
>> > 
>> > Pushed to drm-intel for 4.14, thanks.  
>> 
>> Probably deserves to be in fixes if we identify what introduced the CRC
>> dep. mst-dp? pipe crc?
>
> Looks like
>
> 579cea5f3 ("drm/i915/gvt: golden virtual HW state management")

Thus the select should've been under DRM_I915_GVT.

BR,
Jani.


>
> Thanks,
> Nick
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Jani Nikula, Intel Open Source Technology Center