Re: [PATCHv2 1/1] deb-pkg: Add device tree blobs to the package

[Arnaud Patard (Rtp) <arnaud.patard@rtp-net.org>]

Michal Marek <mmarek@suse.cz> writes:

> On 2015-01-22 15:19, Ben Hutchings wrote:
>> On Thu, 2015-01-22 at 14:40 +0100, Michal Marek wrote:
>>> On 2015-01-20 17:04, Ben Hutchings wrote:
>>>> On Tue, 2015-01-20 at 00:13 +0100, Arnaud Patard wrote:
>>>>> Ben Hutchings <ben@decadent.org.uk> writes:
>>>>>> Only arm and arm64 support that target.  You should maybe run something
>>>>>> like 'make -n dtbs_install >/dev/null 2>&1' first to check that the
>>>>>> target is defined.
>>>>>
>>>>> There's a 'set -e' on top of the script so using make -n will likely
>>>>> result in the script failing, which wouldn't be so nice imho.
>>>> [...]
>>>>
>>>> That's why you use it with the if statement:
>>>>
>>>> # Only some architectures with OF support have this target
>>>> if make -n dtbs_install >/dev/null 2>&1; then
>>>
>>> The problem is that kbuild does not support make -n and some of the
>>> commands are always executed. So the command will silently build the
>>> blobs and just not install them.
>> 
>> If the dtbs_install target is defined, they should already have been
>> built at this point.  If the target is not defined, why would it do
>> anything?
>
> The point is that make -n does not work with kbuild. It might work for
> this specific case, but there is no guarantee that it will continue to
> do so.
>

Ok, so a patch with make -n will be refused, right ?

>
>>> if grep -q dtbs_install "arch/$SRCARCH/Makefile"; then
>>>   ...
>>>
>>> and hope that there won't be any comment causing a false positive.
>>> Another option is to grep 'make help' output.
>> 
>> Ugh.
>
> I know that both options are ugly :).

Let's go to your first options then. I feel not really motivated by
parsing 'make help' output.

Arnaud