From: Reinhard Tartler <Reinhard.Tartler@informatik.uni-erlangen.de>
To: linux-kbuild@vger.kernel.org
Cc: Jean Sacren <sakiwit@gmail.com>, Michal Marek <mmarek@suse.cz>,
linux-kernel@vger.kernel.org,
vamos-dev@lists.informatik.uni-erlangen.de
Subject: [PATCH] kconfig: Fix checking return value of 'fwrite'
Date: Thu, 06 Oct 2011 13:14:36 +0200 [thread overview]
Message-ID: <87lisype1v.fsf@faui43f.informatik.uni-erlangen.de> (raw)
fwrite indicates '1' written member if a zero-length string is written.
---
scripts/kconfig/lkc.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h
index b633bdb..727d265 100644
--- a/scripts/kconfig/lkc.h
+++ b/scripts/kconfig/lkc.h
@@ -90,7 +90,7 @@ struct conf_printer {
/* confdata.c and expr.c */
static inline void xfwrite(const void *str, size_t len, size_t count, FILE *out)
{
- if (fwrite(str, len, count, out) < count)
+ if (len > 0 && fwrite(str, len, count, out) < count)
fprintf(stderr, "\nError in writing or end of file.\n");
}
--
1.7.0.4
--
Reinhard Tartler Department of Computer Science IV
Martensstr 1, 91058 Erlangen Germany, University of Erlangen-Nuremberg
http://www4.informatik.uni-erlangen.de/~tartler
next reply other threads:[~2011-10-06 11:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 11:14 Reinhard Tartler [this message]
2011-10-07 2:34 ` [PATCH] kconfig: Fix checking return value of 'fwrite' Cong Wang
2011-10-07 3:29 ` Arnaud Lacombe
2011-11-20 13:24 ` Michal Marek
2011-11-20 15:53 ` Reinhard Tartler
2011-11-23 5:53 ` Jean Sacren
2011-11-23 6:30 ` Reinhard Tartler
2011-11-23 18:05 ` Arnaud Lacombe
2011-11-25 23:42 ` [PATCH] kbuild: Fix compiler warning with assertion when calling 'fwrite' Jean Sacren
2012-01-14 23:19 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lisype1v.fsf@faui43f.informatik.uni-erlangen.de \
--to=reinhard.tartler@informatik.uni-erlangen.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sakiwit@gmail.com \
--cc=vamos-dev@lists.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox