From: Rusty Russell <rusty@rustcorp.com.au>
To: Jan Beulich <JBeulich@novell.com>,
Alessio Igor Bogani <abogani@kernel.org>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: sorting of exports breaks modpost's GPL checking
Date: Thu, 07 Jul 2011 10:33:11 +0930 [thread overview]
Message-ID: <87oc16kils.fsf@rustcorp.com.au> (raw)
In-Reply-To: <4E12F9EB020000780004C219@nat28.tlf.novell.com>
On Tue, 05 Jul 2011 10:47:55 +0100, "Jan Beulich" <JBeulich@novell.com> wrote:
> >>> On 05.07.11 at 11:36, Alessio Igor Bogani <abogani@kernel.org> wrote:
> > Dear Mr. Beulich,
> >
> > 2011/7/4 Jan Beulich <JBeulich@novell.com>:
> >> Is it known (and being worked on) that exported symbols residing
> >> themselves in modules are no longer properly handled by modpost,
> >> due to the .o files to be linked into .ko (other than vmlinux and the
> >> .ko files) still carrying the ___ksymtab*+<symbol> sections?
> >>
> >> If not - what are the thoughts to resolve this?
> > [...]
> >
> > Could you tell me how reproduce the problem?
>
> Just look at Modules.symvers - all the symbols coming from modules
> will be tagged "(unknown)" rather than EXPORT_SYMBOL,
> EXPORT_SYMBOL_GPL, etc.
>
> As to reproducing the actual bad behavior - creating a non-GPL
> module that consumes a GPL-only export should be all you need.
>
> Jan
We could just drop this detection. It's a courtesy, after all: the gpl
stuff is enforced at runtime.
Thoughts?
Rusty.
next prev parent reply other threads:[~2011-07-07 7:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 15:00 sorting of exports breaks modpost's GPL checking Jan Beulich
2011-07-05 9:36 ` Alessio Igor Bogani
2011-07-05 9:47 ` Jan Beulich
2011-07-07 1:03 ` Rusty Russell [this message]
2011-07-07 8:09 ` Jan Beulich
2011-07-07 12:17 ` Alessio Igor Bogani
2011-07-09 23:13 ` [PATCH] modpost: Fix modpost's license checking Alessio Igor Bogani
2011-07-10 6:08 ` Arnaud Lacombe
2011-07-12 7:00 ` [PATCH] modpost: Fix modpost's license checking V2 Alessio Igor Bogani
2011-07-12 18:02 ` Anders Kaseorg
2011-07-12 18:15 ` Arnaud Lacombe
2011-07-12 18:35 ` Anders Kaseorg
2011-07-12 18:49 ` Arnaud Lacombe
2011-07-14 6:51 ` [PATCH] modpost: Fix modpost's license checking V3 Alessio Igor Bogani
2011-07-18 23:38 ` Rusty Russell
2011-07-20 15:25 ` Michal Marek
2011-07-21 6:46 ` Rusty Russell
2012-03-24 2:04 ` Frank Rowand
2012-03-24 2:25 ` Frank Rowand
2012-03-27 1:58 ` Frank Rowand
2012-03-27 7:19 ` Alessio Igor Bogani
2012-03-27 22:59 ` Frank Rowand
2012-03-28 8:04 ` Alessio Igor Bogani
2012-03-29 4:37 ` Rusty Russell
2012-04-10 0:59 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oc16kils.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=JBeulich@novell.com \
--cc=abogani@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox