From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michal Marek <mmarek@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH v2] tags: honor COMPILED_SOURCE with apart output directory
Date: Tue, 25 Apr 2017 22:07:47 +0200 [thread overview]
Message-ID: <87shkwi73g.fsf@belgarion.home> (raw)
In-Reply-To: <CAK7LNAQN2ZRFETM818ySYSOx1Tykhq7RCYeyFv=x1ARH7w7cww@mail.gmail.com> (Masahiro Yamada's message of "Tue, 25 Apr 2017 03:06:04 +0900")
Masahiro Yamada <yamada.masahiro@socionext.com> writes:
> Hi Robert,
>> diff --git a/scripts/tags.sh b/scripts/tags.sh
>> index a2ff3388e5ea..35cb64d5211c 100755
>> --- a/scripts/tags.sh
>> +++ b/scripts/tags.sh
>> @@ -106,7 +106,8 @@ all_compiled_sources()
>> case "$i" in
>> *.[cS])
>> j=${i/\.[cS]/\.o}
>> - if [ -e $j ]; then
>> + k="${j#$tree}"
>> + if [ -e $j -o -e "$k" ]; then
>
>
> Do we need to check both srctree and objtree?
> I think checking objtree (after $tree is ripped off) is enough.
If I remember correctly, as this goes back a couple of monthes when I made the
tests of this patch, the srctree is checked for the case when the kernel is
compiled without O=, and objtree for the case with O=.
Cheers.
--
Robert
next prev parent reply other threads:[~2017-04-25 20:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 16:35 [PATCH v2] tags: honor COMPILED_SOURCE with apart output directory Robert Jarzmik
2017-01-23 6:22 ` Robert Jarzmik
2017-02-14 7:33 ` Robert Jarzmik
2017-04-24 18:06 ` Masahiro Yamada
2017-04-25 20:07 ` Robert Jarzmik [this message]
2017-04-30 14:53 ` Masahiro Yamada
2017-05-04 6:29 ` Robert Jarzmik
2017-05-06 15:57 ` Masahiro Yamada
2017-06-05 6:05 ` Masahiro Yamada
2017-06-05 6:16 ` Masahiro Yamada
2017-06-05 12:00 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shkwi73g.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox