Re: [PATCH] dtc: Ensure #line directives don't consume data from the next line

Stephen Warren
2013-05-31T17:42:11Z

On 05/31/2013 11:38 AM, Andreas Schwab wrote:
> Stephen Warren <swarren@wwwdotorg.org> writes:
>
>> Fix this by replacing {WS} with [ \t] so that it can't match line-breaks.
>
> I think the other uses of {WS} shouldn't span lines either.

That is true, but only the optional occurrence /should/ matter. Any
changes to the other occurrences would only affect malformed #line
directives, whereas changing this one occurrence would also affect
well-formed #line directives, due to the optional nature of the trailing
flags field.

Still, it may be reasonable just to change all the occurrences anyway.
Does anyone have a strong opinion either way?