From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 657CDCDB482 for ; Wed, 11 Oct 2023 20:54:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235233AbjJKUyV (ORCPT ); Wed, 11 Oct 2023 16:54:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233507AbjJKUyU (ORCPT ); Wed, 11 Oct 2023 16:54:20 -0400 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F376E90 for ; Wed, 11 Oct 2023 13:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697057659; x=1728593659; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=QNf3Q7ICUXumxY53qJthomE1Ml2suVDO5yj6WJnjsFU=; b=NTGsnnX+JdfuC9OUpv4KLysNohaAIm25GtluEQzDdANT+dEi5IER7WYD 8ntBFZBCU+Sb5vMz3Cv7Hfn+9tTFBUZFsUc54ULe79C9Yn1sowUsI6gv5 is7rFDtiwrsCHkskeCpbwSXvT9BJ7QviIXbHYyAA3W415zuf9ccoyjqOM dnfzMMjb5MjVF2U1qfEnNkv51ydetg30SviB/7LK8vl67L9E3QCTMu/KE rKKF6IZTSYMS06ffDFa70DtJ7LUpRKLXidnp8z+IMLLpnQKxNCu+fl223 L1QuhCo3lYFsnHdB4VMQtx4HPXytXatOvE1Cpkq6OLtyW0x8L+RDExNFm g==; X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="3352203" X-IronPort-AV: E=Sophos;i="6.03,217,1694761200"; d="scan'208";a="3352203" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 13:54:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10860"; a="897794990" X-IronPort-AV: E=Sophos;i="6.03,217,1694761200"; d="scan'208";a="897794990" Received: from lpaczyn-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.57.43]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Oct 2023 13:52:29 -0700 From: Jani Nikula To: Masahiro Yamada Cc: intel-gfx@lists.freedesktop.org, linux-kbuild@vger.kernel.org, Arnd Bergmann , Nick Desaulniers , Nathan Chancellor Subject: Re: [PATCH v2 2/2] drm/i915: enable W=1 warnings by default In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <69a812273091b6535ddc7f9346289d71bb30f43d.1697009258.git.jani.nikula@intel.com> Date: Wed, 11 Oct 2023 23:54:13 +0300 Message-ID: <87wmvs3moa.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Wed, 11 Oct 2023, Masahiro Yamada wrote: > On Wed, Oct 11, 2023 at 4:29=E2=80=AFPM Jani Nikula wrote: >> >> We enable a bunch more compiler warnings than the kernel >> defaults. However, they've drifted to become a unique set of warnings, >> and have increasingly fallen behind from the W=3D1 set. >> >> Align with the W=3D1 warnings from scripts/Makefile.extrawarn for clarit= y, >> by copy-pasting them with s/KBUILD_CFLAGS/subdir-ccflags-y/ to make it >> easier to compare in the future. >> >> Some of the -Wextra warnings do need to be disabled, just like in >> Makefile.extrawarn, but take care to not disable them for W=3D2 or W=3D3 >> builds, depending on the warning. >> >> v2: Add back some -Wextra warning disables (Nathan) >> >> Cc: Arnd Bergmann >> Cc: Nick Desaulniers >> Cc: Nathan Chancellor >> Cc: Masahiro Yamada >> Reviewed-by: Nathan Chancellor >> Signed-off-by: Jani Nikula > > Reviewed-by: Masahiro Yamada Thanks for the reviews everyone... ...though we missed some s/KBUILD_CFLAGS/subdir-ccflags-y/ in v2. Fixed while applying. BR, Jani. --=20 Jani Nikula, Intel