From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1711238423D; Wed, 15 Jul 2026 07:29:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784100574; cv=none; b=SqUMsxgRt5HJo4EWepF7qx+TtwSLiDzj7LKx5ewtjSvZYc9M8oBdTgbTQ3eFI7/fNRtoFPeH3Gjcau3ZlkR/822n+Z5pA50WByVe0NTPfmBao7g5xAMGN5rMtOu37ZWzBncvIvM7Ja/OqkpYaYoPIP+1etiodWD8DqwKfb6yJ00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784100574; c=relaxed/simple; bh=tiqPd9mBkUzeSfUEuQX09eSn+SMM0nvXgq6NfrOX4W8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=rka1QKCF+UIcmsKv++YZE3rWF4e8ZqP6SOqont3d+s7aCU0Nb5islNHba2D3G0UfjyEo7Q6xXKvvrh0rt+TWYyt+FUeXJr9y1M46DmHNNnWJdDmDM4gtrK91jSqUa3DLFBuL74uO0EHAKwbD9s4N7FE7a5thkkJcwZJG9Q0v9WY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RJ0obCk2; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RJ0obCk2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AC081F000E9; Wed, 15 Jul 2026 07:29:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784100571; bh=oxqnySUc8Q87H9Bf1NcMH+aFYiamz3WK9FMyyvPdOHQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=RJ0obCk28CVa5NZXZuu1pUdenmJYIQlEs6MMF67avt9Mea6LpcXDIVL7emcqswy6r UgkNH7iltfdTsoSvDqFc79LhJfEhvqLhukc8Y/Q7laC5Z3yORMErsR1kYSgdpXfpDv H294L8Bf0ZCUGCplE4gq8sNMKQkSdNub3bGtTv3li48WsKckEvHNQXqbU3oeh1YSIp LcPVP513nmLfDBhvxLMKjr6P7w/49KZEyBsdIErNONwnpRw9kAf9IjWCSHp51bmaed mJ2iLNKEjZ3M2DA8TSMw2ugIPQced7dtn11Lt7Kygqdu+qA7a2QO/oKJt7ahGJJVzL mLJU3KRFXEyxA== From: Thomas Gleixner To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Arnd Bergmann , Andy Lutomirski , Vincenzo Frascino , Nathan Chancellor , Nicolas Schier , Thomas Bogendoerfer , Daniel Lezcano , Mark Rutland , Marc Zyngier , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Huacai Chen , WANG Xuerui Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, loongarch@lists.linux.dev, Thomas =?utf-8?Q?Wei=C3=9Fschuh?= Subject: Re: [PATCH 2/7] vDSO: Make clockmode constants available without CONFIG_GENERIC_GETTIMEOFDAY In-Reply-To: <20260709-vdso-arch-clockmodes-v1-2-3fd780bbf851@linutronix.de> References: <20260709-vdso-arch-clockmodes-v1-0-3fd780bbf851@linutronix.de> <20260709-vdso-arch-clockmodes-v1-2-3fd780bbf851@linutronix.de> Date: Wed, 15 Jul 2026 09:29:26 +0200 Message-ID: <87zezsogmh.ffs@fw13> Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, Jul 09 2026 at 13:32, Thomas Wei=C3=9Fschuh wrote: > diff --git a/include/asm-generic/Kbuild b/include/asm-generic/Kbuild > index 15df9dcb42a5..2bc00c67dc54 100644 > --- a/include/asm-generic/Kbuild > +++ b/include/asm-generic/Kbuild > @@ -62,6 +62,7 @@ mandatory-y +=3D topology.h > mandatory-y +=3D trace_clock.h > mandatory-y +=3D uaccess.h > mandatory-y +=3D unwind_user.h > +mandatory-y +=3D vdso/clocksource.h > mandatory-y +=3D vermagic.h > mandatory-y +=3D vga.h > mandatory-y +=3D video.h > diff --git a/include/asm-generic/vdso/clocksource.h b/include/asm-generic= /vdso/clocksource.h > new file mode 100644 > index 000000000000..e69de29bb2d1 > diff --git a/include/vdso/clocksource.h b/include/vdso/clocksource.h > index c682e7c60273..63ee8c4ea15c 100644 > --- a/include/vdso/clocksource.h > +++ b/include/vdso/clocksource.h > @@ -4,9 +4,12 @@ >=20=20 > #include >=20=20 > -#ifdef CONFIG_GENERIC_GETTIMEOFDAY > #include > -#endif /* CONFIG_GENERIC_GETTIMEOFDAY */ > + > +#if !IS_ENABLED(CONFIG_GENERIC_GETTIMEOFDAY) && defined(VDSO_ARCH_CLOCKM= ODES) > +/* Unlinkable dummy stubs */ > +extern int VDSO_ARCH_CLOCKMODES; > +#endif I'm utterly confused by this. What's this unlinkable stub for? The only usage of VDSO_ARCH_CLOCKMODES is in enum vdso_clock_modes where it is guarded with CONFIG_GENERIC_GETTIMEOFDAY. And your change log says: > Provide unlinkable dummy definitions. These can be used with > IS_ENABLED(CONFIG_GENERIC_GETTIMEOFDAY). which is even more confusing because that's related to the actual architecture specific defines and not to VDSO_ARCH_CLOCKMODES. None of this makes sense to me. Thanks, tglx