From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 973B1205E2E for ; Mon, 16 Dec 2024 14:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734360198; cv=none; b=DxSDLrgQ9OzjpcV1veyDvNaTcdMJvviS1DRUh9unhSrq0gDqOCgaLyXD2CsemwF4us5sA8wpr59I6OkUWxHi7QFvodCefLo/epjH77nwk8y/VNju4E7J+peuFe4UjmwcuEzZZoFW25Yz+n4bY6wGJ14iXL2lc6iM6rk8nwhpUK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734360198; c=relaxed/simple; bh=vid6eL2+9lF17Od0L9ytahZMwPP7rZ9zJw0QfkIJvkw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WA/zgoK9fYYoIrO0MrIfIxA1LwV0ZLcWlde0aJy7XbG3EE7Zsww9e59Gi6vfru59xThVtqssc0zbyPR8Ne1OoOQW/n+LMZef45WechyZGrT0sAzKXkSyf2kTMSRtdQXuCMh82AhsibqL50jxrYkowHF1j79k+FCFmMf0JzAHpnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=AZtqCNaA; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="AZtqCNaA" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-216395e151bso27299805ad.0 for ; Mon, 16 Dec 2024 06:43:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1734360195; x=1734964995; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cmrCxqpDqjESJ70QFxTBBLdJXAN7riBEqPMzA//neTs=; b=AZtqCNaA/Z0SYtsDC+ARqA8ngylWvfVuCm4l/ErosMiGE+oEkeJOp3h6+UlhgQknn7 b1uDWcXd+oqzCOtyOYWTC0TlOg5rlfPK0cN8ItwErecLdOfr2TrXYAJXXHskyoxnfs3l 9mUCx/BCYspbEY+GMFcxGEsncWocHWh6hoZ8XJmxMsIs3913LnmEjuhLoRywme2HCQ/J e1M1eOuyMdmdoCpqlKO1/tKmD5KK77ObrcntN51Fft1k59SwVjE0gYaX3Z2gnKXDIeSe hxkFb8m4Q4VXoOfoTgppoN3KgDjaGnh86lQhWSqMGJ4TdP5aDi6j88SnEqA/FsWAc0cD d+LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734360195; x=1734964995; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cmrCxqpDqjESJ70QFxTBBLdJXAN7riBEqPMzA//neTs=; b=ZiiO7aZGqCKHv8xnUEpd9a/UZWTli0pMHS131/FgC/x9GRwuwVpXBo4eLWpvgOLSW5 zhRfFOqP6aqXAJZOpNFbA4JDM/VQJ2JqsiBjJdMXWMVp7GjDipUfCeZxK6Ii3+ulIIpB RQ5+7eYWNMK1qD5KxfXUuO/Z1ySWaE5TDczwqhmVmLBOmsLVs8fBLGlusKHHm7mT9Z1M APkqAS7JXakA/jPFbCWmeeIVvnTEw/NFcpKnahA5aoe2+xPSdNNTShrliDxFgHuqXInk W81N4KiJJzCtfjARoWBJtdqeN1z0yCg3YyPom2ZP5SsGfzjdWIgry5TFHI/xynDPC/UR 4uLQ== X-Forwarded-Encrypted: i=1; AJvYcCVkxV47HOgCGlKc7l+zOIew1sgSPGr5t17XG+uWkpKpYBqnD6WRqQBQmK/0VpHU5uCroT0hMocw/Uz6pnA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzfd1+A9/zu5KStQV2B8Xq8gvLO7FjHgkm7Pq8xkQinl9fwNkcB fsGRHG7zyL+4UxErXdtC68uE/lNjaFohEKWncofXxmu25qhK4uhjAAQ1ObZvJcw= X-Gm-Gg: ASbGncsDtuosai0DUyOUvJj/YfRZeWaQPXaNOSUNnF7k01JMvZdZPGk5X0A8GlYBvKQ i1V8CVE2EEc4SGfdV8y1s5WsRZ3cd0yddIW7mI/mPgtqabRSIvSiWoTM8busrOIDc/ZX14G+8TX Pb7q9WctTzF+5HYSCVBWvK9/X6Y1trgOYPRy2nTGySBqzJZ0zil7TQtylA122PUoG6QGxwxkdoN e0VoTxV6WzyxjN40a1DbpVD2yKoPJMgo9av0gBKLSqUfNj1jrff9g== X-Google-Smtp-Source: AGHT+IHnVO9LhhiLRU5ZRt5v3Hbaaa13fz1HBag4AymzRth1YKtvqbofDh9Crx+RLV4GTPXrrpUfPg== X-Received: by 2002:a17:902:f607:b0:215:98e7:9b1 with SMTP id d9443c01a7336-21893b53528mr185076855ad.5.1734360195579; Mon, 16 Dec 2024 06:43:15 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-218a1db7976sm43700335ad.53.2024.12.16.06.43.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2024 06:43:14 -0800 (PST) Message-ID: <8e1b5c5e-52ae-4332-a49c-990add7611f6@kernel.dk> Date: Mon, 16 Dec 2024 07:43:12 -0700 Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] rust: extend `module!` macro with integer parameter support To: Andreas Hindborg , Greg KH Cc: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Alice Ryhl , Masahiro Yamada , Nathan Chancellor , Nicolas Schier , Trevor Gross , Adam Bratschi-Kaye , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org References: <20241213-module-params-v3-v3-0-485a015ac2cf@kernel.org> <4Dsa69UGULRGsMbRbwOJNp_puyfsSSFt1QTcYU9AL4azd8vbfEFFtc7YNSsGegc40AfCZqVqZETfxg4TggUlSw==@protonmail.internalid> <2024121324-overdue-giggly-bdb8@gregkh> <87frmrepo5.fsf@kernel.org> <2024121309-lethargic-ended-5f99@gregkh> <87ttb7d24p.fsf@kernel.org> <2024121344-excusably-resurrect-d01a@gregkh> <87h674c5vq.fsf@kernel.org> <2024121646-shelve-series-5319@gregkh> <877c7zbx2u.fsf@kernel.org> Content-Language: en-US From: Jens Axboe In-Reply-To: <877c7zbx2u.fsf@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/16/24 6:02 AM, Andreas Hindborg wrote: >>> I understand that you would like to phase out module parameters, but I >>> don't think blocking their use from Rust is the right way to go about >>> that task. If you really feel that module parameters have no place in >>> new drivers, I would suggest that to be part of review process for each >>> individual new driver - not at the stage of enabling module parameters >>> for Rust in general. >> >> I'm saying that module parameters do NOT belong in a driver, which is >> what you are wanting to do here. And as for adding new apis, please >> only do so when you have a real user, I don't see a real user for module >> parameters in rust just yet. If that changes, I'll reconsider my stance :) > > I guess we disagree about what is "real" and what is not. > > In my view, null_blk is real, it is used by real people to do real work. > They get real annoyed when the interface for their real tools change - > thus making it more difficult to do this experiment. I'd have to agree with that - yes, null_blk doesn't host any real applications, but it is the backbone of a lot of testing that blktests and others do. Hence it's very real in that sense, and the rust version of null_blk should provide and mimic how the C version works for ease of testing. If this was a new driver where no prior art exists in terms of users and API, then I'd certainly agree with Greg. But that's not the case here. -- Jens Axboe