Re: [PATCH v4 13/19] gendwarfksyms: Add symbol versioning

Sami Tolvanen
2024-10-23T17:46:53Z

Hi Petr,

On Tue, Oct 22, 2024 at 4:48 AM Petr Pavlu <petr.pavlu@suse.com> wrote:
>
> I had some minor comment about adjusting the name of function
> symbol_print_versions() and possibly changing sym->name to 'char *' on
> the v2 of the patch:
> https://lore.kernel.org/all/286b1cc5-1757-4f0a-bb66-0875f4608c7e@suse.com/
> Please have a look, it seems it felt through the cracks.

Sorry, I missed that somehow. I can split this into two functions to
avoid confusion. Also I'm using const char * to make it obvious that
the name shouldn't be modified by users of struct symbol. This does
require a cast when freeing the string, which isn't ideal, but I feel
it's overall not a terrible trade-off.

Sami