Re: [PATCH v4 18/19] kbuild: Add gendwarfksyms as an alternative to genksyms

Sami Tolvanen
2024-10-23T21:15:08Z

Hi,

On Wed, Oct 23, 2024 at 2:59 PM Petr Pavlu <petr.pavlu@suse.com> wrote:
>
> On 10/8/24 20:38, Sami Tolvanen wrote:
> > +gendwarfksyms := scripts/gendwarfksyms/gendwarfksyms
> > +getexportsymbols = $(NM) $(1) | sed -n 's/.* __export_symbol_\(.*\)/$(2)/p'
> > +
> > genksyms = scripts/genksyms/genksyms \
> > $(if $(1), -T $(2)) \
> > $(if $(KBUILD_PRESERVE), -p) \
> > -r $(or $(wildcard $(2:.symtypes=.symref)), /dev/null)
> >
> > # These mirror gensymtypes_S and co below, keep them in synch.
> > +ifdef CONFIG_GENDWARFKSYMS
> > +symtypes_dep_c = $(obj)/%.o
> > +cmd_gensymtypes_c = $(if $(skip_gendwarfksyms),, \
> > + $(call getexportsymbols,$(2:.symtypes=.o),\1) | \
> > + $(gendwarfksyms) $(2:.symtypes=.o) $(if $(1), --symtypes $(2)))
>
> Is it possible to pass options to gendwarfksyms that apply to the entire
> build, specifically, how can one say to use the --stable option? If not
> then I think it would be good to add something as
> KBUILD_GENDWARFKSYMS_STABLE (similar to KBUILD_PRESERVE), or maybe
> a generic GENDWARFKSYMSFLAGS?

Yeah, I left that as an exercise to the user in this version, but I
agree, adding a KBUILD_ flag seems reasonable.

Sami