Re: [PATCH v4 09/19] gendwarfksyms: Expand structure types

Petr Pavlu
2024-10-22T11:42:48Z

On 10/8/24 20:38, Sami Tolvanen wrote:
> Recursively expand DWARF structure types, i.e. structs, unions, and
> enums. Also include relevant DWARF attributes in type strings to
> encode structure layout, for example.
>
> Example output with --dump-dies:
>
> subprogram (
> formal_parameter structure_type &str {
> member pointer_type {
> base_type u8 byte_size(1) encoding(7)
> } data_ptr data_member_location(0) ,
> member base_type usize byte_size(8) encoding(7) length data_member_location(8)
> } byte_size(16) alignment(8) msg
> )
> -> base_type void
>
> Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
> Acked-by: Neal Gompa <neal@gompa.dev>

Looks ok to me, feel free to add:

Reviewed-by: Petr Pavlu <petr.pavlu@suse.com>

-- Petr