From: Dragan Simic <dsimic@manjaro.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jose Ignacio Tornos Martinez <jtornosm@redhat.com>,
UNGLinuxDriver@microchip.com, davem@davemloft.net,
edumazet@google.com, f.fainelli@gmail.com,
gregkh@linuxfoundation.org, kuba@kernel.org,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, lucas.demarchi@intel.com,
masahiroy@kernel.org, mcgrof@kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, woojung.huh@microchip.com
Subject: Re: [PATCH] net: usb: lan78xx: add weak dependency with micrel phy module
Date: Sat, 27 Jul 2024 19:15:26 +0200 [thread overview]
Message-ID: <931b582808f237aa3746c5b0a96b3665@manjaro.org> (raw)
In-Reply-To: <b96d9801-d370-4ddd-97fd-5eac2a2656f4@lunn.ch>
Hello,
On 2024-07-26 22:59, Andrew Lunn wrote:
> On Fri, Jul 26, 2024 at 02:15:26PM +0200, Jose Ignacio Tornos Martinez
> wrote:
>> Hello Andrew,
>>
>> > What this does appear to do is differentiate between 'pre' which will
>> > load the kernel module before it is requested. Since there is no 'pre'
>> > for this, it seems pointless whacking this mole.
>>
>> Precisely, we need to fix the lan78xx case with micrel phy (and other
>> possible phy modules) too, due to the commented issue generating
>> initramfs
>> in order to include the phy module.
>
> I still don't see how this solves any issues with generating the
> initramfs.
>
> There are more than 200 Ethernet drivers, and around 75 PHY
> drivers. If this patch is merged, you have one MAC driver indicating
> it needs one PHY driver. There is nothing much you can do with that
> information. You need to wait until 99% of the MAC drivers indicate
> which PHY drivers are needed. Then you can use this information leave
> out any PHY which is not needed, and hope you only break a small
> number of devices. But even if you wait 20 years i doubt you will get
> 99% of the MAC drivers indicating what PHY drivers you need. Because
> nothing really uses this information today.
>
> So as far as i see, this has nothing to do with building the
> initramfs.
Before going into explaining my viewpoint, could someone, please,
clarify
which LAN78xx USB-to-Ethernet bridge does this apply to? I already had
a look at a few LAN78xx datasheets, and I'm not sure how the external
PHY
becomes exposed over the USB interface, so it needs a driver.
next prev parent reply other threads:[~2024-07-27 17:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240724145458.440023-1-jtornosm@redhat.com>
[not found] ` <20240724161020.442958-1-jtornosm@redhat.com>
[not found] ` <8a267e73-1acc-480f-a9b3-6c4517ba317a@lunn.ch>
[not found] ` <v6uovbn7ld3vlym65twtcvximgudddgvvhsh6heicbprcs5ii3@nernzyc5vu3i>
[not found] ` <32be761b-cebc-48e4-a36f-bbf90654df82@gmail.com>
2024-07-25 6:50 ` [PATCH] net: usb: lan78xx: add weak dependency with micrel phy module Lucas De Marchi
2024-07-25 9:53 ` Paolo Abeni
2024-07-26 11:33 ` Andrew Lunn
2024-07-26 12:15 ` Jose Ignacio Tornos Martinez
2024-07-26 20:59 ` Andrew Lunn
2024-07-27 17:15 ` Dragan Simic [this message]
2024-07-27 23:29 ` Andrew Lunn
2024-07-28 14:10 ` Dragan Simic
2024-07-28 19:45 ` Andrew Lunn
2024-07-28 20:46 ` Dragan Simic
2024-07-28 20:57 ` Andrew Lunn
2024-07-29 4:43 ` Dragan Simic
2024-07-29 6:13 ` Greg KH
2024-07-29 6:29 ` Dragan Simic
2024-07-29 8:34 ` Jose Ignacio Tornos Martinez
2024-07-29 9:28 ` Dragan Simic
2024-07-29 12:32 ` Jose Ignacio Tornos Martinez
2024-07-29 18:56 ` Andrew Lunn
2024-07-30 7:55 ` Jose Ignacio Tornos Martinez
2024-07-28 7:37 ` Masahiro Yamada
2024-07-28 9:53 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=931b582808f237aa3746c5b0a96b3665@manjaro.org \
--to=dsimic@manjaro.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jtornosm@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox