From: Arnaud Lacombe <lacombar@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [RFC 7/9] kbuild: merge parser generation rules
Date: Thu, 5 May 2011 10:50:27 -0400 [thread overview]
Message-ID: <BANLkTim_PynQaLWfg3ExmBGEwZzFfGdRCQ@mail.gmail.com> (raw)
In-Reply-To: <20110505133203.GE13293@sepie.suse.cz>
Hi,
On Thu, May 5, 2011 at 9:32 AM, Michal Marek <mmarek@suse.cz> wrote:
> Hi Arnaud,
>
> nice cleanup, I only have a few random comments to this and other patches.
>
> On Wed, May 04, 2011 at 10:03:22PM -0400, Arnaud Lacombe wrote:
>> # Shipped files
>> # ===========================================================================
>>
>> quiet_cmd_shipped = SHIPPED $@
>> cmd_shipped = cat $< > $@
>>
>> -$(obj)/%:: $(src)/%_shipped
>> +$(obj)/%.tab.c: $(src)/%.tab.c_shipped
>> + $(call cmd,shipped)
>> +
>> +$(obj)/lex.%.c: $(src)/lex.%.c_shipped
>> + $(call cmd,shipped)
>> +
>> +$(obj)/%.hash.c: $(src)/%.hash.c_shipped
>> $(call cmd,shipped)
>
> Please don't change this rule, there are other uses of _shipped files in the
> tree than just bison/lex/gperf generated files.
>
I could not make the other implicit target work without changing this one. Ie:
$(src)/%.tab.c_shipped: $(src)/%.y
$(call cmd,bison)
was not working with the _shipped rules left intact, but hardcoding
stem value, eg.:
$(src)/zconf.tab.c_shipped: $(src)/zconf.y
$(call cmd,bison)
was working, at least to link the different implicit target, but
that's breaking other part. I'll try to re-investigate tonight.
- Arnaud
next prev parent reply other threads:[~2011-05-05 14:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 2:03 [RFC 0/9] Kbuild: factor parser rules Arnaud Lacombe
2011-05-05 2:03 ` [RFC 2/9] genksyms: finalize rename Arnaud Lacombe
2011-05-05 2:06 ` Arnaud Lacombe
2011-05-05 14:23 ` Michal Marek
2011-05-23 2:17 ` Arnaud Lacombe
2011-05-23 3:32 ` Arnaud Lacombe
2011-05-05 2:03 ` [RFC 3/9] genksyms: pass hash and lookup functions name and target language though the input file Arnaud Lacombe
2011-05-05 2:03 ` [RFC 4/9] genksyms: regen parser Arnaud Lacombe
2011-05-05 2:03 ` [RFC 5/9] kconfig: constify `kconf_id_lookup' Arnaud Lacombe
2011-05-05 2:03 ` [RFC 6/9] kconfig: regen parsers Arnaud Lacombe
2011-05-05 2:03 ` [RFC 7/9] kbuild: merge parser generation rules Arnaud Lacombe
2011-05-05 13:32 ` Michal Marek
2011-05-05 14:50 ` Arnaud Lacombe [this message]
2011-05-05 2:03 ` [RFC 8/9] kconfig: regen parser Arnaud Lacombe
2011-05-05 2:03 ` [RFC 9/9] genksyms: " Arnaud Lacombe
[not found] ` <1304561004-2684-2-git-send-email-lacombar@gmail.com>
2011-05-05 14:18 ` [RFC 1/9] genksyms: rename parser files Michal Marek
2011-05-23 2:06 ` Arnaud Lacombe
2011-05-23 5:48 ` Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim_PynQaLWfg3ExmBGEwZzFfGdRCQ@mail.gmail.com \
--to=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox