* [PATCH 1/1] kconfig: fix 'space' to (de)select options
@ 2025-06-21 8:41 Cherniaev Andrei
2025-06-24 10:03 ` Masahiro Yamada
0 siblings, 1 reply; 2+ messages in thread
From: Cherniaev Andrei @ 2025-06-21 8:41 UTC (permalink / raw)
To: linux-kbuild; +Cc: masahiroy, yann.morin.1998, linux-kernel, Cherniaev Andrei
Fix that by treating 'space' as we treat y/m/n, ie. as an action key, not as shortcut to jump to prompt. This is copy of commit https://gitlab.com/buildroot.org/buildroot/-/raw/master/support/kconfig/patches/16-fix-space-to-de-select-options.patch
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>
---
| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c
index 6e6244df0c56..d4c19b7beebb 100644
--- a/scripts/kconfig/lxdialog/menubox.c
+++ b/scripts/kconfig/lxdialog/menubox.c
@@ -264,7 +264,7 @@ int dialog_menu(const char *title, const char *prompt,
if (key < 256 && isalpha(key))
key = tolower(key);
- if (strchr("ynmh", key))
+ if (strchr("ynmh ", key))
i = max_choice;
else {
for (i = choice + 1; i < max_choice; i++) {
--
2.48.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] kconfig: fix 'space' to (de)select options
2025-06-21 8:41 [PATCH 1/1] kconfig: fix 'space' to (de)select options Cherniaev Andrei
@ 2025-06-24 10:03 ` Masahiro Yamada
0 siblings, 0 replies; 2+ messages in thread
From: Masahiro Yamada @ 2025-06-24 10:03 UTC (permalink / raw)
To: Cherniaev Andrei; +Cc: linux-kbuild, yann.morin.1998, linux-kernel
On Sat, Jun 21, 2025 at 5:51 PM Cherniaev Andrei
<dungeonlords789@naver.com> wrote:
>
> Fix that by treating 'space' as we treat y/m/n, ie. as an action key, not as shortcut to jump to prompt. This is copy of commit https://gitlab.com/buildroot.org/buildroot/-/raw/master/support/kconfig/patches/16-fix-space-to-de-select-options.patch
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Cherniaev Andrei <dungeonlords789@naver.com>
> ---
> scripts/kconfig/lxdialog/menubox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/lxdialog/menubox.c b/scripts/kconfig/lxdialog/menubox.c
> index 6e6244df0c56..d4c19b7beebb 100644
> --- a/scripts/kconfig/lxdialog/menubox.c
> +++ b/scripts/kconfig/lxdialog/menubox.c
> @@ -264,7 +264,7 @@ int dialog_menu(const char *title, const char *prompt,
> if (key < 256 && isalpha(key))
> key = tolower(key);
>
> - if (strchr("ynmh", key))
> + if (strchr("ynmh ", key))
> i = max_choice;
> else {
> for (i = choice + 1; i < max_choice; i++) {
> --
> 2.48.1
>
I will take directly from Buildroot (with your signed-off),
as this commit provides more details about how to reproduce the issue.
https://gitlab.com/buildroot.org/buildroot/-/commit/c6597e5aa3fa4bb52e9749797c90467083aa363b
Thanks
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-06-24 10:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-21 8:41 [PATCH 1/1] kconfig: fix 'space' to (de)select options Cherniaev Andrei
2025-06-24 10:03 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).