* Re: [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper
2026-01-18 22:30 ` [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper Miguel Ojeda
@ 2026-01-19 13:30 ` Chen Miao
2026-01-19 14:16 ` Benno Lossin
2026-01-20 11:13 ` Nicolas Schier
2 siblings, 0 replies; 4+ messages in thread
From: Chen Miao @ 2026-01-19 13:30 UTC (permalink / raw)
To: Miguel Ojeda, Benno Lossin, Nathan Chancellor, Nicolas Schier,
Tamir Duberstein
Cc: tamird, da.gomez, hust-os-kernel-patches, linux-kernel,
rust-for-linux, Linux Kbuild mailing list, Boqun Feng, Gary Guo,
Björn Roy Baron, Andreas Hindborg, Alice Ryhl, Trevor Gross,
Danilo Krummrich
在 2026/1/19 06:30, Miguel Ojeda 写道:
> On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chenmiao@openatom.club> wrote:
>> When I enabled Rust compilation, I wanted to clean up its output, so I
>> used make clean and make mrproper. However, I was still able to find that
>> libpin_init_internal.so in the rust directory was not deleted, while
>> all other corresponding outputs were cleared.
>>
>> Dongliang Mu <dzm91@hust.edu.cn>
> This line seems broken. Was this meant to be a Reviewed-by, like in v1?
Yes, it should be `Reviewed-by`.
>> Signed-off-by: chenmiao <chenmiao@openatom.club>
> I think in another patch/thread you mentioned this should be "Chen Miao", right?
Yes, Please modify this to Chen Miao.
>
> No need for a new patch, I can fix both on apply if you agree.
>
> Adding the relevant people to Cc (pin-init, Kbuild and Rust). And
> Tamir for the `.dylib` side.
>
> Also, I guess we could backport this:
>
> Fixes: d7659acca7a3 ("rust: add pin-init crate build infrastructure")
> Cc: stable@vger.kernel.org
>
> Cheers,
> Miguel
If it’s convenient for you, I think your proposal sounds great and I agree.
Thanks for the review.
Regards,
Chen Miao
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper
2026-01-18 22:30 ` [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper Miguel Ojeda
2026-01-19 13:30 ` Chen Miao
@ 2026-01-19 14:16 ` Benno Lossin
2026-01-20 11:13 ` Nicolas Schier
2 siblings, 0 replies; 4+ messages in thread
From: Benno Lossin @ 2026-01-19 14:16 UTC (permalink / raw)
To: Miguel Ojeda, chenmiao, Nathan Chancellor, Nicolas Schier,
Tamir Duberstein
Cc: tamird, da.gomez, hust-os-kernel-patches, linux-kernel,
rust-for-linux, Linux Kbuild mailing list, Boqun Feng, Gary Guo,
Björn Roy Baron, Andreas Hindborg, Alice Ryhl, Trevor Gross,
Danilo Krummrich
On Sun Jan 18, 2026 at 11:30 PM CET, Miguel Ojeda wrote:
> On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chenmiao@openatom.club> wrote:
>>
>> When I enabled Rust compilation, I wanted to clean up its output, so I
>> used make clean and make mrproper. However, I was still able to find that
>> libpin_init_internal.so in the rust directory was not deleted, while
>> all other corresponding outputs were cleared.
>>
>> Dongliang Mu <dzm91@hust.edu.cn>
>
> This line seems broken. Was this meant to be a Reviewed-by, like in v1?
>
>> Signed-off-by: chenmiao <chenmiao@openatom.club>
>
> I think in another patch/thread you mentioned this should be "Chen Miao", right?
>
> No need for a new patch, I can fix both on apply if you agree.
>
> Adding the relevant people to Cc (pin-init, Kbuild and Rust). And
> Tamir for the `.dylib` side.
Acked-by: Benno Lossin <lossin@kernel.org>
Cheers,
Benno
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper
2026-01-18 22:30 ` [PATCH v2] Makefile: Remove the product of pin_init cleanly in mrporper Miguel Ojeda
2026-01-19 13:30 ` Chen Miao
2026-01-19 14:16 ` Benno Lossin
@ 2026-01-20 11:13 ` Nicolas Schier
2 siblings, 0 replies; 4+ messages in thread
From: Nicolas Schier @ 2026-01-20 11:13 UTC (permalink / raw)
To: Miguel Ojeda
Cc: chenmiao, Benno Lossin, Nathan Chancellor, Tamir Duberstein,
tamird, da.gomez, hust-os-kernel-patches, linux-kernel,
rust-for-linux, Linux Kbuild mailing list, Boqun Feng, Gary Guo,
Björn Roy Baron, Andreas Hindborg, Alice Ryhl, Trevor Gross,
Danilo Krummrich
On Sun, Jan 18, 2026 at 11:30:47PM +0100, Miguel Ojeda wrote:
> On Fri, Oct 31, 2025 at 3:32 AM chenmiao <chenmiao@openatom.club> wrote:
> >
> > When I enabled Rust compilation, I wanted to clean up its output, so I
> > used make clean and make mrproper. However, I was still able to find that
> > libpin_init_internal.so in the rust directory was not deleted, while
> > all other corresponding outputs were cleared.
> >
> > Dongliang Mu <dzm91@hust.edu.cn>
>
> This line seems broken. Was this meant to be a Reviewed-by, like in v1?
>
> > Signed-off-by: chenmiao <chenmiao@openatom.club>
>
> I think in another patch/thread you mentioned this should be "Chen Miao", right?
>
> No need for a new patch, I can fix both on apply if you agree.
>
> Adding the relevant people to Cc (pin-init, Kbuild and Rust). And
> Tamir for the `.dylib` side.
>
> Also, I guess we could backport this:
>
> Fixes: d7659acca7a3 ("rust: add pin-init crate build infrastructure")
> Cc: stable@vger.kernel.org
>
Can you please update the typo in the subject:
- prefix: 'rust' or 'kbuild'
- s/mrporper/mrproper/?
Thanks!
Acked-by: Nicolas Schier <nsc@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread