Re: [PATCH 1/2] kbuild: rust: allow `clippy::uninlined_format_args`

Gary Guo
2026-04-01T15:36:44Z

On Tue Mar 31, 2026 at 10:53 PM BST, Miguel Ojeda wrote:
> On Tue, Mar 31, 2026 at 11:43 PM Gary Guo <gary@garyguo.net> wrote:
>>
>> I mean the lint is kinda useful, and I don't want to disable it just because
>> it doesn't exist in older versions of rustc.
>
> Yeah, personally I like the inlined way, i.e. I use it myself, so I
> don't mind enabling it everywhere if people is happy that it only
> applies to some cases.
>
> Another consideration is that the issue linked mentions that they
> don't want to mix inline and not (for field access cases), so that
> could be annoying for some, which is why they moved it back.

For mixed cases I suppose it's really up to personal taste. In that case we can
say it does have "false positive" and allow the lint.

Best,
Gary

>
> Either way sounds fine for me.
>
> Anyway, if we enable it, I should apply the other suggestion too, put
> the Cc: stable@ on them, and switch to `-W` here and remove the Cc:
> stable@.
>
> Thanks for taking a look!
>
> Cheers,
> Miguel