public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Jon Loeliger <jdl@jdl.com>
To: Michal Marek <mmarek@suse.cz>
Cc: Andrej Krutak <andree@andree.sk>, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] Fix build failure on cygwin.
Date: Mon, 02 Apr 2012 17:22:09 -0500	[thread overview]
Message-ID: <E1SEpdZ-0000dW-8Z@jdl.com> (raw)
In-Reply-To: <4F7A1AA6.8000702@suse.cz>

> Adding Jon Loeliger (dtc maintainer) to CC.
> 
> Dne 2.4.2012 16:05, Andrej Krutak napsal(a):
> > The _B macro is defined by cygwin in ctype.h.
> > Move the inclusion to avoid build failure.
> 
> But nothing prevents the other system headers from including <ctype.h>
> earlier :-(. A more robust fix would be to rename the macro to something
> that does not clash (fdt_b??). But that's up to Jon.
> 
> Michal

Folks,

I'll happily accept a patch to rename _B() to something better
or eliminate it entirely.  Patch to devtree-discuss@lists.ozlabs.org
and CC:'ed to jdl@jdl.com, please.

Thanks,
jdl

  reply	other threads:[~2012-04-02 22:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 14:05 [PATCH] Fix build failure on cygwin Andrej Krutak
2012-04-02 21:31 ` Michal Marek
2012-04-02 22:22   ` Jon Loeliger [this message]
2012-04-03  6:35     ` [PATCH] Rename _B to _XBYTE in libfdt_env.h Andrej Krutak
2012-04-09 13:49       ` Jon Loeliger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1SEpdZ-0000dW-8Z@jdl.com \
    --to=jdl@jdl.com \
    --cc=andree@andree.sk \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox