From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7E91C433FE for ; Sun, 20 Nov 2022 13:55:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229586AbiKTNzd (ORCPT ); Sun, 20 Nov 2022 08:55:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbiKTNzb (ORCPT ); Sun, 20 Nov 2022 08:55:31 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58E1F12D1E; Sun, 20 Nov 2022 05:55:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668952530; x=1700488530; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=6oz/VGdHbmnvKnjIBkMxIP78ltMPsharNqLSWuk0xuk=; b=UbQIeKvWEQLfUe0vxAZ7mxayS5abA8Llq2JtN1+ZtsNOIbRq3/Cfa77y iZqnQ3/vbaEFjhDwcUd98MvRVCnxvnmPmx3ngn+61fhHrynIqBY2jiLqw xrG6BampbB25emJzKicvBRXQ+uopz9NlL/k7bz3okXnJL9TXD3L4732o9 LrKaeTncvnMzTqYywGEegvJ9sadycPhiXBMOXIDOhYm4918VAS7rhFEGz prjwA297TzWq9BUyr/GUzHOYqaoKmPf7k4bOqf4nH1TyTS9+k8xS0LzDT 5h8rpxRRVBM/xd1OVIOkm0J41BD8HrirPudtcQ6xSmkx3zB8RJzxd8O/c Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10536"; a="296760503" X-IronPort-AV: E=Sophos;i="5.96,179,1665471600"; d="scan'208";a="296760503" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2022 05:55:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10536"; a="640740467" X-IronPort-AV: E=Sophos;i="5.96,179,1665471600"; d="scan'208";a="640740467" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 20 Nov 2022 05:55:24 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1owkn3-00Eqr5-1w; Sun, 20 Nov 2022 15:55:21 +0200 Date: Sun, 20 Nov 2022 15:55:21 +0200 From: Andy Shevchenko To: Alexander Lobakin Cc: linux-kbuild@vger.kernel.org, Masahiro Yamada , Nicolas Schier , Jens Axboe , Boris Brezillon , Borislav Petkov , Tony Luck , Miquel Raynal , Vladimir Oltean , Alexandre Belloni , Derek Chickles , Ioana Ciornei , Salil Mehta , Sunil Goutham , Grygorii Strashko , Daniel Scally , Hans de Goede , Mark Brown , NXP Linux Team , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/18] platform/x86: int3472: fix object shared between several modules Message-ID: References: <20221119225650.1044591-1-alobakin@pm.me> <20221119225650.1044591-12-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221119225650.1044591-12-alobakin@pm.me> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org On Sat, Nov 19, 2022 at 11:08:17PM +0000, Alexander Lobakin wrote: > common.o is linked to both intel_skl_int3472_{discrete,tps68470}: > > > scripts/Makefile.build:252: ./drivers/platform/x86/intel/int3472/Makefile: > > common.o is added to multiple modules: intel_skl_int3472_discrete > > intel_skl_int3472_tps68470 > > Although both drivers share one Kconfig option > (CONFIG_INTEL_SKL_INT3472), it's better to not link one object file > into several modules (and/or vmlinux). > Under certain circumstances, such can lead to the situation fixed by > commit 637a642f5ca5 ("zstd: Fixing mixed module-builtin objects"). > > Introduce the new module, intel_skl_int3472_common, to provide the > functions from common.o to both discrete and tps68470 drivers. This > adds only 3 exports and doesn't provide any changes to the actual > code. ... > +MODULE_IMPORT_NS(INTEL_SKL_INT3472); > + Redundant blank line. You may put it to be last MODULE_*() in the file, if you think it would be more visible. > MODULE_DESCRIPTION("Intel SkyLake INT3472 ACPI Discrete Device Driver"); > MODULE_AUTHOR("Daniel Scally "); > MODULE_LICENSE("GPL v2"); ... > +MODULE_IMPORT_NS(INTEL_SKL_INT3472); > + > MODULE_DESCRIPTION("Intel SkyLake INT3472 ACPI TPS68470 Device Driver"); > MODULE_AUTHOR("Daniel Scally "); > MODULE_LICENSE("GPL v2"); Ditto. And the same to all your patches. -- With Best Regards, Andy Shevchenko