From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] kbuild: unify cmd_dt_S_dtb and cmd_dt_S_dtbo
Date: Thu, 29 Dec 2022 20:47:15 +0100 [thread overview]
Message-ID: <Y63uw1HGiL5ZxJkk@fjasle.eu> (raw)
In-Reply-To: <20221229184650.1107463-1-masahiroy@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1771 bytes --]
On Fri, Dec 30, 2022 at 03:46:50AM +0900 Masahiro Yamada wrote:
> cmd_dt_S_dtb and cmd_dt_S_dtbo are almost the same; the only differnce
> is the prefix of the bein/end symbols. (__dtb vs __dtbo)
Two letters got lost: differ_e_nce, be_g_in.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> scripts/Makefile.lib | 45 +++++++++++++++-----------------------------
> 1 file changed, 15 insertions(+), 30 deletions(-)
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 4a4a5f67c1a6..100a386fcd71 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -368,40 +368,25 @@ DTC_FLAGS += $(DTC_FLAGS_$(basetarget))
> DTC_FLAGS += $(if $(filter $(patsubst $(obj)/%,%,$@), $(base-dtb-y)), -@)
>
> # Generate an assembly file to wrap the output of the device tree compiler
> -quiet_cmd_dt_S_dtb= DTBS $@
> -cmd_dt_S_dtb= \
> -{ \
> - echo '\#include <asm-generic/vmlinux.lds.h>'; \
> - echo '.section .dtb.init.rodata,"a"'; \
> - echo '.balign STRUCT_ALIGNMENT'; \
> - echo '.global __dtb_$(subst -,_,$(*F))_begin'; \
> - echo '__dtb_$(subst -,_,$(*F))_begin:'; \
> - echo '.incbin "$<" '; \
> - echo '__dtb_$(subst -,_,$(*F))_end:'; \
> - echo '.global __dtb_$(subst -,_,$(*F))_end'; \
> - echo '.balign STRUCT_ALIGNMENT'; \
> -} > $@
> +quiet_cmd_wrap_S_dtb = WRAP $@
> + cmd_wrap_S_dtb = { \
> + symbase=__$(patsubst .%,%,$(suffix $<))_$(subst -,_,$(notdir $*)); \
As long as I know, '$(notdir $*)' should be equivalent to '$(*F)'. Is it just
personal preference or is there some other reason for choosing one or the
other?
Nevertheless, with the typos fixed, it looks good to me:
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-12-29 19:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-29 18:46 [PATCH] kbuild: unify cmd_dt_S_dtb and cmd_dt_S_dtbo Masahiro Yamada
2022-12-29 19:47 ` Nicolas Schier [this message]
2022-12-30 3:08 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y63uw1HGiL5ZxJkk@fjasle.eu \
--to=nicolas@fjasle.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox