From: Nicolas Schier <nicolas@fjasle.eu>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH] kbuild: replace $(dot-target).tmp in filechk with $(tmp-target)
Date: Mon, 9 Jan 2023 16:27:29 +0100 [thread overview]
Message-ID: <Y7wyYe52A6U5qOAQ@fjasle.eu> (raw)
In-Reply-To: <20230109134040.3191458-1-masahiroy@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]
On Mon, Jan 09, 2023 at 10:40:40PM +0900 Masahiro Yamada wrote:
> $(tmp-target) is a better fit for local use like this.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> scripts/Kbuild.include | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
> index 4648ab8f11d4..7778cc97a4e0 100644
> --- a/scripts/Kbuild.include
> +++ b/scripts/Kbuild.include
> @@ -99,11 +99,11 @@ define filechk
> $(check-FORCE)
> $(Q)set -e; \
> mkdir -p $(dir $@); \
> - trap "rm -f $(dot-target).tmp" EXIT; \
> - { $(filechk_$(1)); } > $(dot-target).tmp; \
> - if [ ! -r $@ ] || ! cmp -s $@ $(dot-target).tmp; then \
> + trap "rm -f $(tmp-target)" EXIT; \
> + { $(filechk_$(1)); } > $(tmp-target); \
> + if [ ! -r $@ ] || ! cmp -s $@ $(tmp-target); then \
> $(kecho) ' UPD $@'; \
> - mv -f $(dot-target).tmp $@; \
> + mv -f $(tmp-target) $@; \
> fi
> endef
>
> --
> 2.34.1
I do fully agree.
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2023-01-09 15:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 13:40 [PATCH] kbuild: replace $(dot-target).tmp in filechk with $(tmp-target) Masahiro Yamada
2023-01-09 15:27 ` Nicolas Schier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7wyYe52A6U5qOAQ@fjasle.eu \
--to=nicolas@fjasle.eu \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox